From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17B61C79F85 for ; Sat, 5 Sep 2026 15:21:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Mqo0BMx1ifj9a2kCuZrCJMvmSnufIkatqKGeQLf7b/s=; b=VNv2t9gM+q7GAVl+7tGp+762JY B8+OgWlEgfBvUfLi4BnehLEHPnFzPK76m9fRKdhDFvHg/cw/TER9dNrSoEBl+Gw2Q5OdaBQNiu9fP CZOagvTp9an1F/WLRQEeZZbUR0Yj4ZiNrfjDiDsCaBqhrbVNKmglTjTm+tWDzJt7QREfpI+L5LNur GImuMjZ7WQsfk45Twq9fJnsXR71tf8gAYtWs98PVuwsmfvpeL7kPAJ0Aa9dfZSSysZXGOAaxfxFpJ Dcji28NXNNhlsrnkFDq3I5eqdFjWWILdcm2WR/ZoeyuxPXuh3/BF91+pk5oJ2yR4KSEWV5hYzbVo2 oqtIXfKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x2sCr-00000004Bgk-3GMI; Sat, 05 Sep 2026 15:21:25 +0000 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x2sCp-00000004Bel-03KF for linux-um@lists.infradead.org; Sat, 05 Sep 2026 15:21:24 +0000 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-49b8e527d63so25005165e9.2 for ; Sat, 05 Sep 2026 08:21:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788621681; x=1789226481; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Mqo0BMx1ifj9a2kCuZrCJMvmSnufIkatqKGeQLf7b/s=; b=qW/MDGi7Yku+LLEB4eRJ9/vsgSkp+y2eR5YOFmdgDHPgfGfPtZz/ztCYv/3oW6GmDX EgiACv9Lmyy3MLd08t3zX86dwOrXGXj/j1ZRBVYChjl1G/QC5SmroUITY2HfDPbTj3Lg GXd22+MFegBGK+4DmNgXZamAs2FpKm1ml083181gGmN5wwowpDT9RWPsNQbS2YooNHOM D1+cc64Lrm/87epBgyz866TPjJyGWgpD8Xd/h+3+UVM0rX2e7R4JjE27DbdtOSR5JxvO dHZUSLjMkSZ28Ha6VYdV6mSisPNI0cBfd/mgxtgVTdFbLDQBqbCZ9S99heFhe5hRoKsk NPmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788621681; x=1789226481; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Mqo0BMx1ifj9a2kCuZrCJMvmSnufIkatqKGeQLf7b/s=; b=LoT6DrsKlERncXLVO19peSOhk8A0OYojzvA64CbEv/gw+1gi6Wu+RdTyjHXCggFYc5 4hJ1LW0pWNpeLsIQzoK++i0DCZrrcIFIahwMJxD5iWs7U1dq/AhwcGfUyLZO6z2BNlMw vrS1JaK9lO8QM/9aEfUgVVZDU9cfTbl7KT8IGro1MPOp1hFV9AYh2o1OkI+d2ZN4FBEq cLePdGahCCGnS2V5W8Zs+eRIh2YNeMCHGTdNgC3y6LUYU/H9dzVe9EScoqsgH2VUvuws hHOI+vYFktfzrTDdR+EEm7ToipdBQC33dPjX8LoJjyyhr0MVAmCVrYCFKPp0M/BJ6/dx rxLg== X-Forwarded-Encrypted: i=1; AKwUvByzomjPD7nq5zIfuITtksTiWKGlFURkw4rmuq8KGsqxn6Pkf5zOb8ZCtLfGkzjZSkn69OILb8hUSg==@lists.infradead.org X-Gm-Message-State: AFuF++mPTPreKlBruQKhtXnpEFpJBlGoFkTGX6PD3Q9zy5elrdgoH7ly OeAOgpmHmwGW+hYBupm9zrSYENJFva7jhLBtSbaikvujAzQH7QdwkUAf X-Gm-Gg: AYBFou0MU4jf0WdaQjyE/634tcIEVfZRi7LUH+zgdC8GHDDFM+yzt7eVoS3is73iC2N SziyOAHCHyJVjg1hwlQQNYQXmy9MRwSDFvQ8sIJt1UX7V12AzNw1kSvpCDo0JKCc4b0IKMF5Hpv 67/gQTf0SqOyZKAjTarpBebotbFaubLzwL6Fj07byNQrxjmxJ5TkSHonoNgUfh7GUddlnK1pi6g rq5XC8XebqfXf5omFCCRaUTNapA8XPcentfG7ZJP62qMFPfrccQPHHjKiSii0wv7WbIrHuumPOh QTR6XwN87JFr/gBHtZF1WiJqKjvvFPeAzWjqt1rK33QlE2RhBg6urvMxmzJ5eRvwtVM7ufTGqfl WLw1kKa6wiFcG9UdSHKKTQ4v/eWW6VtexiPmUjPB6lFfE4YSuw/VLajVwBLMlOfh/Ab9Z6uAzbk vcR2QtSg9S9D0IXP44R3zV65ZPpA89rBvlNXsMh68VZR6uOiMwGHeGDqSuwKNCE/gt+BLVuv0Ab iWWpFaPfBtOu8M63vRMdyVirKPcjmyHTKMMN6rumjlrU6sqIs3T35vUsEpPNKzoO4La3lgALdiQ m5fCbKhaZ7KthaHS2dl0OjkhZD3YwKg/pNuJO99n7bflgNz88npKcguikEv+vmRHrtg= X-Received: by 2002:a05:600c:1d2a:b0:49b:12c2:104f with SMTP id 5b1f17b1804b1-49cf81e52e8mr117561445e9.1.1788621680621; Sat, 05 Sep 2026 08:21:20 -0700 (PDT) Received: from localhost.localdomain (dynamic-2a02-3100-a4eb-3001-c06d-af27-9fa2-ea53.310.pool.telefonica.de. [2a02:3100:a4eb:3001:c06d:af27:9fa2:ea53]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cf75ce49esm267779515e9.1.2026.09.05.08.21.19 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 05 Sep 2026 08:21:20 -0700 (PDT) From: Karl Mehltretter To: "Michael S . Tsirkin" , Jason Wang , Gerd Hoffmann Cc: Karl Mehltretter , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Dmitry Torokhov , Rusty Russell , Pawel Moll , Cornelia Huck , Halil Pasic , Eric Farman , Richard Weinberger , Anton Ivanov , Johannes Berg , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , virtualization@lists.linux.dev, linux-input@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, linux-um@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/3] virtio: implement synchronize_cbs for remaining transports Date: Sat, 5 Sep 2026 17:20:59 +0200 Message-Id: <20260905152059.89560-4-kmehltretter@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20260905152059.89560-1-kmehltretter@gmail.com> References: <20260905152059.89560-1-kmehltretter@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260905_082123_112377_3C92E0C3 X-CRM114-Status: GOOD ( 22.98 ) X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org virtio_reset_device() now calls synchronize_cbs to wait for running callbacks. Its synchronize_rcu() fallback does not cover workqueue or sleepable callbacks. Add the missing hooks. UML waits for its shared IRQ; TmFIFO takes the existing per-direction locks held around vring_interrupt(). Virtio-vdpa uses a per-device rwlock around its callbacks, which must already be hard-IRQ safe. Remoteproc callbacks can run in hard-IRQ or process context, and rpmsg callbacks can sleep, so use one SRCU domain per rproc. Enter it before looking up the queue. Initialize it in rproc_alloc(), returning NULL if that fails, and clean it up at final release. cleanup_srcu_struct() can sleep, so document that rproc_put() and rproc_free() may sleep when dropping the last reference. These hooks wait for callbacks already running. UML, TmFIFO and remoteproc still allow new callbacks after reset. Suggested-by: Michael S. Tsirkin Assisted-by: LLM Signed-off-by: Karl Mehltretter --- arch/um/drivers/virtio_uml.c | 10 ++++++++++ drivers/platform/mellanox/mlxbf-tmfifo.c | 14 ++++++++++++++ drivers/remoteproc/remoteproc_core.c | 10 ++++++++++ drivers/remoteproc/remoteproc_virtio.c | 20 +++++++++++++++++--- drivers/virtio/virtio_vdpa.c | 21 ++++++++++++++++++++- include/linux/remoteproc.h | 3 +++ 6 files changed, 74 insertions(+), 4 deletions(-) diff --git a/arch/um/drivers/virtio_uml.c b/arch/um/drivers/virtio_uml.c index 7425a8548141..baca6b09e9ac 100644 --- a/arch/um/drivers/virtio_uml.c +++ b/arch/um/drivers/virtio_uml.c @@ -20,6 +20,7 @@ * * Based on Virtio MMIO driver by Pawel Moll, copyright 2011-2014, ARM Ltd. */ +#include #include #include #include @@ -869,6 +870,14 @@ static void vu_reset(struct virtio_device *vdev) vu_dev->status = 0; } +static void vu_synchronize_cbs(struct virtio_device *vdev) +{ + struct virtio_uml_device *vu_dev = to_virtio_uml_device(vdev); + + if (vu_dev->irq >= 0) + synchronize_irq(vu_dev->irq); +} + static void vu_del_vq(struct virtqueue *vq) { struct virtio_uml_vq_info *info = vq->priv; @@ -1121,6 +1130,7 @@ static const struct virtio_config_ops virtio_uml_config_ops = { .reset = vu_reset, .find_vqs = vu_find_vqs, .del_vqs = vu_del_vqs, + .synchronize_cbs = vu_synchronize_cbs, .get_features = vu_get_features, .finalize_features = vu_finalize_features, .bus_name = vu_bus_name, diff --git a/drivers/platform/mellanox/mlxbf-tmfifo.c b/drivers/platform/mellanox/mlxbf-tmfifo.c index 3c6408581373..c260e3a1544e 100644 --- a/drivers/platform/mellanox/mlxbf-tmfifo.c +++ b/drivers/platform/mellanox/mlxbf-tmfifo.c @@ -1135,6 +1135,19 @@ static void mlxbf_tmfifo_virtio_reset(struct virtio_device *vdev) tm_vdev->status = 0; } +static void mlxbf_tmfifo_virtio_synchronize_cbs(struct virtio_device *vdev) +{ + struct mlxbf_tmfifo_vdev *tm_vdev = mlxbf_vdev_to_tmfifo(vdev); + struct mlxbf_tmfifo *fifo = tm_vdev->vrings[0].fifo; + unsigned long flags; + int i; + + for (i = 0; i < ARRAY_SIZE(fifo->spin_lock); i++) { + spin_lock_irqsave(&fifo->spin_lock[i], flags); + spin_unlock_irqrestore(&fifo->spin_lock[i], flags); + } +} + /* Read the value of a configuration field. */ static void mlxbf_tmfifo_virtio_get(struct virtio_device *vdev, unsigned int offset, @@ -1179,6 +1192,7 @@ static const struct virtio_config_ops mlxbf_tmfifo_virtio_config_ops = { .find_vqs = mlxbf_tmfifo_virtio_find_vqs, .del_vqs = mlxbf_tmfifo_virtio_del_vqs, .reset = mlxbf_tmfifo_virtio_reset, + .synchronize_cbs = mlxbf_tmfifo_virtio_synchronize_cbs, .set_status = mlxbf_tmfifo_virtio_set_status, .get_status = mlxbf_tmfifo_virtio_get_status, .get = mlxbf_tmfifo_virtio_get, diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index 1ed406714849..1b139d25ab2b 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -2410,6 +2410,7 @@ static void rproc_type_release(struct device *dev) dev_info(&rproc->dev, "releasing %s\n", rproc->name); + cleanup_srcu_struct(&rproc->vq_srcu); idr_destroy(&rproc->notifyids); if (rproc->index >= 0) @@ -2507,6 +2508,11 @@ struct rproc *rproc_alloc(struct device *dev, const char *name, if (!rproc) return NULL; + if (init_srcu_struct(&rproc->vq_srcu)) { + kfree(rproc); + return NULL; + } + rproc->priv = &rproc[1]; rproc->auto_boot = true; rproc->elf_class = ELFCLASSNONE; @@ -2571,6 +2577,8 @@ EXPORT_SYMBOL(rproc_alloc); * * If no one holds any reference to rproc anymore, then its refcount would * now drop to zero, and it would be freed. + * + * Context: May sleep if this drops the last reference. */ void rproc_free(struct rproc *rproc) { @@ -2586,6 +2594,8 @@ EXPORT_SYMBOL(rproc_free); * * If no one holds any reference to rproc anymore, then its refcount would * now drop to zero, and it would be freed. + * + * Context: May sleep if this drops the last reference. */ void rproc_put(struct rproc *rproc) { diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c index d5e9ff045a28..ecc022e354db 100644 --- a/drivers/remoteproc/remoteproc_virtio.c +++ b/drivers/remoteproc/remoteproc_virtio.c @@ -23,6 +23,7 @@ #include #include #include +#include #include "remoteproc_internal.h" @@ -89,14 +90,19 @@ static bool rproc_virtio_notify(struct virtqueue *vq) irqreturn_t rproc_vq_interrupt(struct rproc *rproc, int notifyid) { struct rproc_vring *rvring; + int srcu_idx; + irqreturn_t ret; + + srcu_idx = srcu_read_lock(&rproc->vq_srcu); dev_dbg(&rproc->dev, "vq index %d is interrupted\n", notifyid); rvring = idr_find(&rproc->notifyids, notifyid); - if (!rvring || !rvring->vq) - return IRQ_NONE; + ret = rvring && rvring->vq ? vring_interrupt(0, rvring->vq) : IRQ_NONE; + + srcu_read_unlock(&rproc->vq_srcu, srcu_idx); - return vring_interrupt(0, rvring->vq); + return ret; } EXPORT_SYMBOL(rproc_vq_interrupt); @@ -242,6 +248,13 @@ static void rproc_virtio_reset(struct virtio_device *vdev) dev_dbg(&vdev->dev, "reset !\n"); } +static void rproc_virtio_synchronize_cbs(struct virtio_device *vdev) +{ + struct rproc *rproc = vdev_to_rproc(vdev); + + synchronize_srcu(&rproc->vq_srcu); +} + /* provide the vdev features as retrieved from the firmware */ static u64 rproc_virtio_get_features(struct virtio_device *vdev) { @@ -330,6 +343,7 @@ static const struct virtio_config_ops rproc_virtio_config_ops = { .find_vqs = rproc_virtio_find_vqs, .del_vqs = rproc_virtio_del_vqs, .reset = rproc_virtio_reset, + .synchronize_cbs = rproc_virtio_synchronize_cbs, .set_status = rproc_virtio_set_status, .get_status = rproc_virtio_get_status, .get = rproc_virtio_get, diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c index de2af696de6c..4f9e70c1332e 100644 --- a/drivers/virtio/virtio_vdpa.c +++ b/drivers/virtio/virtio_vdpa.c @@ -27,6 +27,7 @@ struct virtio_vdpa_device { struct virtio_device vdev; struct vdpa_device *vdpa; + rwlock_t callback_lock; u64 features; }; @@ -123,8 +124,24 @@ static irqreturn_t virtio_vdpa_config_cb(void *private) static irqreturn_t virtio_vdpa_virtqueue_cb(void *private) { struct virtqueue *vq = private; + struct virtio_vdpa_device *vd_dev; + unsigned long flags; + irqreturn_t ret; - return vring_interrupt(0, vq); + vd_dev = to_virtio_vdpa_device(vq->vdev); + read_lock_irqsave(&vd_dev->callback_lock, flags); + ret = vring_interrupt(0, vq); + read_unlock_irqrestore(&vd_dev->callback_lock, flags); + + return ret; +} + +static void virtio_vdpa_synchronize_cbs(struct virtio_device *vdev) +{ + struct virtio_vdpa_device *vd_dev = to_virtio_vdpa_device(vdev); + + write_lock_irq(&vd_dev->callback_lock); + write_unlock_irq(&vd_dev->callback_lock); } static struct virtqueue * @@ -439,6 +456,7 @@ static const struct virtio_config_ops virtio_vdpa_config_ops = { .reset = virtio_vdpa_reset, .find_vqs = virtio_vdpa_find_vqs, .del_vqs = virtio_vdpa_del_vqs, + .synchronize_cbs = virtio_vdpa_synchronize_cbs, .get_features = virtio_vdpa_get_features, .finalize_features = virtio_vdpa_finalize_features, .bus_name = virtio_vdpa_bus_name, @@ -472,6 +490,7 @@ static int virtio_vdpa_probe(struct vdpa_device *vdpa) vd_dev->vdev.config = &virtio_vdpa_config_ops; vd_dev->vdev.map = vdpa->map; vd_dev->vdpa = vdpa; + rwlock_init(&vd_dev->callback_lock); vd_dev->vdev.id.device = ops->get_device_id(vdpa); if (vd_dev->vdev.id.device == 0) diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h index a44368737b39..ad6bccbdfabc 100644 --- a/include/linux/remoteproc.h +++ b/include/linux/remoteproc.h @@ -11,6 +11,7 @@ #include #include #include +#include #include #include #include @@ -230,6 +231,7 @@ enum rproc_features { * @rvdevs: list of remote virtio devices * @subdevs: list of subdevices, to following the running state * @notifyids: idr for dynamically assigning rproc-wide unique notify ids + * @vq_srcu: SRCU domain for virtqueue callbacks * @index: index of this rproc device * @attach_work: workqueue for attaching rproc * @crash_handler: workqueue for handling a crash @@ -276,6 +278,7 @@ struct rproc { struct list_head rvdevs; struct list_head subdevs; struct idr notifyids; + struct srcu_struct vq_srcu; int index; struct work_struct attach_work; struct work_struct crash_handler; -- 2.39.5 (Apple Git-154)