From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F34C1606C453 for ; Wed, 4 Nov 2026 19:51:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=kI9Zfjwo; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=cwHr8orF DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=X/yvfG66BfgMeEDkk3c56eCZsjSg3r6CFhJDsqYaHrc=; b=kI9ZfjwoFSyXuD hfcE10vL0m6Sq1Zm+oTKHH8RMEhUZd5x+Qrs27y3p3jq6dZtNQYPPGnjgkp9dsMNAtHtRcGNT3Tdz RqFneclEa7KnOw5DB0uT0HLI2VGHzQbtNwylJIWln19GLFy31PUqWB7+AXZQWBuZmFFQ3Bvp9Ba6w sTQyKjuJsyKNcNn0JwxCjJwzb1dBoVVawmvWJTplId9By97Hga9nv7VvCM7jd8tyr9L0hj8aNk0lw 37w2sULS7eKMZo9EZZOE+mzWfN3cPWlTdY8nSOCE8J7N52FeGIQvSpqdouvOTs2JWLWrlVo/Nv7Yx wm4+VkNXhmNQFSK0B0pw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xOh1H-00000006mKd-28Iy; Wed, 04 Nov 2026 19:51:39 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xOh1E-00000006mJg-1P50; Wed, 04 Nov 2026 19:51:36 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id C464560F0F; Wed, 4 Nov 2026 19:51:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1974F1F000C1; Wed, 4 Nov 2026 19:51:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793821895; bh=X/yvfG66BfgMeEDkk3c56eCZsjSg3r6CFhJDsqYaHrc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=cwHr8orFnp4x7J2Xe1KsHSEJ1eg0u79nGPLRIUIwbAP0zUf7QsBysosf1FqR5ZX0Q HoxOVOzOEv9f8ZgsLKaGizKxckb+8NmWDvznCxT9hyz6XDje23Fu/BV/7vYfSBlRBo 29q96vKA3sg+WRQgH3Xu5HAtJzyAV0C0X5mRTfioCWgSP85kQ3OB+8joip1pGF4lz6 O/KafZ2Qaez9U/HbkLZAPk5WcEVfLztKFegfM9NGRKV58MPrNpX3BlH061wFYzdEC1 0F3/Xa+OzEI16gZNDCtefEhvwseJTbeAB5Ppvs0OtDpq+EK5pYG3BV1CYUNRgxGUPi Ziv71uisF0tng== From: Christian Brauner To: linux-fsdevel@vger.kernel.org Cc: Linus Torvalds , Jann Horn , Josef Bacik , Chris Mason , Jeff Layton , NeilBrown , Eric Dumazet , Thomas Gleixner , Al Viro , Jonathan Corbet , Christoph Hellwig , Greg Kroah-Hartman , Joel Granados , Kees Cook , Jan Kara , Jan Kara , linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-um@lists.infradead.org, linux-wireless@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, ntfs3@lists.linux.dev, platform-driver-x86@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-pci@vger.kernel.org, linux-sound@vger.kernel.org, netfilter-devel@vger.kernel.org, dri-devel@lists.freedesktop.org, ibm-acpi-devel@lists.sourceforge.net, jfs-discussion@lists.sourceforge.net, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-cifs@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-mm@kvack.org, linux-sh@vger.kernel.org, linux-usb@vger.kernel.org, samba-technical@lists.samba.org, sparclinux@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-doc@vger.kernel.org, linux-serial@vger.kernel.org, linux-atm-general@lists.sourceforge.net, Takashi Iwai , linux-input@vger.kernel.org, linux-raid@vger.kernel.org, linux-ext4@vger.kernel.org, linux-modules@vger.kernel.org, linux-debuggers@vger.kernel.org, "Christian Brauner (Amutable)" , Chuck Lever Subject: [PATCH RESEND v2 07/30] ntfs3: let procfs copy in writes to the label file Date: Wed, 4 Nov 2026 20:51:20 +0100 Message-ID: <20261104-work-procfs-fs-v2-7-319e0f9a8aae@kernel.org> In-Reply-To: <20261104-work-procfs-fs-v2-0-319e0f9a8aae@kernel.org> References: <20261104-work-procfs-fs-v2-0-319e0f9a8aae@kernel.org> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.17-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=2130; i=brauner@kernel.org; h=from:subject:message-id; bh=kxB3eQnJXJ28LS46eI6OZqVe3PV4LPZGCXrTLaq4dFQ=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMWS97jH+72CqrHDmzhLOGyVf5VS7p01fvUvn0De7C5+m2 C7Q/px3v6OUhUGMi0FWTJHFod0kXG45T8Vmo0wNmDmsTCBDGLg4BWAiHx4yMpy3rZ0/Vbh5+gyZ wzeePF8kfWTR38C3305W5Fd5HDHp+GLF8E8x2XK+7nLuldutNvMse8PlwX1u7efe4OOL3l+evkZ A7hkjAA== X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" X-Spam-Status: No, score=-18.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Implement ->proc_write_buf() so procfs copies in what is written before it pins the entry, and set the label from that copy. Writes larger than PAGE_SIZE - 1 bytes fail with -EINVAL from procfs now. A write that large only ever worked when most of it was trailing newlines or came after a NUL, ntfs_set_label() refused a label that long with -ENAMETOOLONG or -EFBIG. Signed-off-by: Christian Brauner (Amutable) --- fs/ntfs3/super.c | 27 +++++++++------------------ 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c index cd47839872b0..cdeccbe506e8 100644 --- a/fs/ntfs3/super.c +++ b/fs/ntfs3/super.c @@ -560,37 +560,28 @@ static int ntfs3_label_show(struct seq_file *m, void *o) } /* write /proc/fs/ntfs3//label */ -static ssize_t ntfs3_label_write(struct file *file, const char __user *buffer, - size_t count, loff_t *ppos) +static ssize_t ntfs3_label_write(struct file *file, char *buf, size_t count, + loff_t *ppos) { int err; struct super_block *sb = pde_data(file_inode(file)); - ssize_t ret = count; - u8 *label; + size_t len = count; if (sb_rdonly(sb)) return -EROFS; - label = memdup_user(buffer, count); - if (IS_ERR(label)) - return PTR_ERR(label); + while (len > 0 && buf[len - 1] == '\n') + len -= 1; - while (ret > 0 && label[ret - 1] == '\n') - ret -= 1; - - err = ntfs_set_label(sb->s_fs_info, label, ret); + err = ntfs_set_label(sb->s_fs_info, (u8 *)buf, len); if (err < 0) { ntfs_err(sb, "failed (%d) to write label", err); - ret = err; - goto out; + return err; } *ppos += count; - ret = count; -out: - kfree(label); - return ret; + return count; } static const struct proc_ops ntfs3_volinfo_fops = { @@ -599,7 +590,7 @@ static const struct proc_ops ntfs3_volinfo_fops = { static const struct proc_ops ntfs3_label_fops = { .proc_show = ntfs3_label_show, - .proc_write = ntfs3_label_write, + .proc_write_buf = ntfs3_label_write, }; static void ntfs_create_procdir(struct super_block *sb) -- 2.53.0