From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from s3.sipsolutions.net ([2a01:4f8:191:4433::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnkFl-008LbN-I1 for linux-um@lists.infradead.org; Thu, 18 Nov 2021 16:27:15 +0000 Message-ID: <21f86e2bc817b6ec0c7a9194a4fefb1d55e3040b.camel@sipsolutions.net> Subject: Re: [tip:x86/core 1/1] arch/x86/um/../lib/csum-partial_64.c:98:12: error: implicit declaration of function 'load_unaligned_zeropad' From: Johannes Berg Date: Thu, 18 Nov 2021 17:26:51 +0100 In-Reply-To: References: <202111180219.YkyoBMpf-lkp@intel.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Peter Zijlstra , Eric Dumazet Cc: kernel test robot , kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, x86@kernel.org, Alexander Duyck , linux-um@lists.infradead.org On Thu, 2021-11-18 at 17:00 +0100, Peter Zijlstra wrote: > On Wed, Nov 17, 2021 at 11:40:35AM -0800, Eric Dumazet wrote: > > On Wed, Nov 17, 2021 at 10:55 AM Eric Dumazet wrote: > > > > > > On Wed, Nov 17, 2021 at 10:46 AM kernel test robot wrote: > > > > > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/core > > > > head: d31c3c683ee668ba5d87c0730610442fd672525f > > > > commit: d31c3c683ee668ba5d87c0730610442fd672525f [1/1] x86/csum: Rewrite/optimize csum_partial() > > > > config: um-x86_64_defconfig (attached as .config) > > > > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > > > > reproduce (this is a W=1 build): > > > > # https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=d31c3c683ee668ba5d87c0730610442fd672525f > > > > git remote add tip https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > > > > git fetch --no-tags tip x86/core > > > > git checkout d31c3c683ee668ba5d87c0730610442fd672525f > > > > # save the attached .config to linux build tree > > > > make W=1 ARCH=um SUBARCH=x86_64 > > > > > > > > If you fix the issue, kindly add following tag as appropriate > > > > Reported-by: kernel test robot > > > > > > > > All errors (new ones prefixed by >>): > > > > > > > > arch/x86/um/../lib/csum-partial_64.c: In function 'csum_partial': > > > > > > arch/x86/um/../lib/csum-partial_64.c:98:12: error: implicit declaration of function 'load_unaligned_zeropad' [-Werror=implicit-function-declaration] > > > > 98 | trail = (load_unaligned_zeropad(buff) << shift) >> shift; > > > > | ^~~~~~~~~~~~~~~~~~~~~~ > > > > cc1: some warnings being treated as errors > > > > > > > > > > > > > > Hmmm... it seems we need to guard this with CONFIG_DCACHE_WORD_ACCESS ? > > > > Perhaps something like the following ? > > Dear um folks, is this indeed the best solution? It's a bit sad to have > to add this to x86_64, but if that's the way it is... > I guess we can add load_unaligned_zeropad() or even just somehow add the include with it (asm/word-at-a-time.h) from x86? johannes _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um