linux-um.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Ritesh Raj Sarraf <rrs@debian.org>
Cc: Ritesh Raj Sarraf <rrs@researchut.com>,
	linux-um@lists.infradead.org, Jeff Dike <jdike@addtoit.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Don't hardcode path as it is architecture dependent
Date: Thu, 20 Sep 2018 21:05:29 +0200	[thread overview]
Message-ID: <2232247.seiAqWBpkp@blindfold> (raw)
In-Reply-To: <20180920062640.23038-1-rrs@debian.org>

Am Donnerstag, 20. September 2018, 08:26:38 CEST schrieb Ritesh Raj Sarraf:
> The current code fails to run on amd64 because of hardcoded reference to
> i386
> 
> Signed-off-by: Ritesh Raj Sarraf <rrs@researchut.com>

Thanks for spotting this!

> ---
>  arch/um/drivers/port_user.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/um/drivers/port_user.c b/arch/um/drivers/port_user.c
> index 9a8e1b64c22e..5f56d11b886f 100644
> --- a/arch/um/drivers/port_user.c
> +++ b/arch/um/drivers/port_user.c
> @@ -168,7 +168,7 @@ int port_connection(int fd, int *socket, int *pid_out)
>  {
>  	int new, err;
>  	char *argv[] = { "/usr/sbin/in.telnetd", "-L",
> -			 "/usr/lib/uml/port-helper", NULL };
> +			 OS_LIB_PATH "/uml/port-helper", NULL };
>  	struct port_pre_exec_data data;
>  
>  	new = accept(fd, NULL, 0);

Thanks,
//richard



_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um


      reply	other threads:[~2018-09-20 19:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-20  6:26 [PATCH] Don't hardcode path as it is architecture dependent Ritesh Raj Sarraf
2018-09-20 19:05 ` Richard Weinberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2232247.seiAqWBpkp@blindfold \
    --to=richard@nod.at \
    --cc=jdike@addtoit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=rrs@debian.org \
    --cc=rrs@researchut.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).