From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 1 Nov 2016 10:26:06 -0400 (EDT) From: Paolo Bonzini Message-ID: <273805880.9973234.1478010366977.JavaMail.zimbra@redhat.com> In-Reply-To: <20161101013749.4003-8-khuey@kylehuey.com> References: <20161101013749.4003-1-khuey@kylehuey.com> <20161101013749.4003-8-khuey@kylehuey.com> Subject: Re: [PATCH v8 7/7] KVM: x86: virtualize cpuid faulting MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org To: Kyle Huey Cc: Robert O'Callahan , Thomas Gleixner , Andy Lutomirski , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Radim =?utf-8?B?S3LEjW3DocWZ?= , Jeff Dike , Richard Weinberger , Alexander Viro , Shuah Khan , Dave Hansen , Borislav Petkov , Peter Zijlstra , Boris Ostrovsky , Len Brown , "Rafael J. Wysocki" , Dmitry Safonov , linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net, user-mode-linux-user@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, kvm@vger.kernel.org List-ID: > + vcpu->arch.cpuid_fault = false; This should be conditional on "if (!init_event)". Most MSRs are untouched on an INIT IPI. Otherwise looks good. The patch is independent of the rest, so I would prefer to take it through the KVM tree. Thanks, Paolo > kvm_make_request(KVM_REQ_EVENT, vcpu); > vcpu->arch.apf.msr_val = 0; > vcpu->arch.st.msr_val = 0; > > kvmclock_reset(vcpu); > > kvm_clear_async_pf_completion_queue(vcpu); > kvm_async_pf_hash_reset(vcpu); > -- > 2.10.2 > >