From: Alex Hung <alex.hung@amd.com>
To: Johannes Berg <johannes@sipsolutions.net>,
richard@nod.at, anton.ivanov@cambridgegreys.com,
linux-um@lists.infradead.org
Cc: Bhawanpreet.Lakha@amd.com
Subject: Re: [PATCH] um: Allow multiple symbol definitions for GCOV builds
Date: Wed, 22 Jul 2026 10:09:06 -0600 [thread overview]
Message-ID: <313f6cf4-91a1-42e7-8e19-d2883c5c4f73@amd.com> (raw)
In-Reply-To: <8b710b01b8117d41281595265da43ab0add10214.camel@sipsolutions.net>
On 7/22/26 08:02, Johannes Berg wrote:
> Hi,
>
> On Tue, 2026-07-21 at 16:23 -0600, Alex Hung wrote:
>>>
>>> I cannot see how that would possibly result in correct behaviour (beyond
>>> being able to link)??
>
>> Good point. --allow-multiple-definition silences the linker error, but
>> picking kernel or libgcov's mangle_path() will break the other at runtime.
>>
>> I saw your previous patch
>> (https://lkml.iu.edu/hypermail/linux/kernel/2103.1/06604.html) to rename
>> mangle_path() to seq_mangle_path(). How about reviving it to avoid name
>> conflicts instead?
>
> Honestly, I completely forgot about that. Looks like I ran into the
> typical "nobody wants to merge it" problem ...
>
> johannes
Is there any concerns or blockers to merge them? I sure want to revive them.
The series may also have a solution for the other patch I sent
(https://lore.kernel.org/linux-um/eea36454-cbbe-4690-980d-b4ec9423f3a0@amd.com/T/#u).
I will test the series and report here later.
next prev parent reply other threads:[~2026-07-22 16:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 22:40 [PATCH] um: Allow multiple symbol definitions for GCOV builds Alex Hung
2026-07-21 21:58 ` Johannes Berg
2026-07-21 22:23 ` Alex Hung
2026-07-22 14:02 ` Johannes Berg
2026-07-22 16:09 ` Alex Hung [this message]
2026-07-22 16:14 ` Johannes Berg
2026-07-24 0:44 ` Alex Hung
2026-07-24 6:42 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=313f6cf4-91a1-42e7-8e19-d2883c5c4f73@amd.com \
--to=alex.hung@amd.com \
--cc=Bhawanpreet.Lakha@amd.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=johannes@sipsolutions.net \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox