From: Richard Weinberger <richard@nod.at>
To: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Cc: user-mode-linux-user@lists.sourceforge.net,
Jeff Dike <jdike@addtoit.com>,
kernel-janitors@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [uml-devel] [PATCH 1/2] um: vector_kern: Unlock on error in vector_net_open()
Date: Mon, 11 Dec 2017 10:33:37 +0100 [thread overview]
Message-ID: <3254171.LO6pLlHuPk@blindfold> (raw)
In-Reply-To: <54b3ee94-6afd-7907-3764-e2413f231209@cambridgegreys.com>
Anton,
Am Samstag, 9. Dezember 2017, 18:09:17 CET schrieb Anton Ivanov:
> Thanks,
>
> I guess I missed that one.
>
> A.
>
> On 09/12/17 11:49, Dan Carpenter wrote:
> > We need to unlock and restore IRQs on this error path.
> >
> > Fixes: ad1f62ab2bd4 ("High Performance UML Vector Network Driver")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c
> > index d1d53015d572..bb83a2d22ac2 100644
> > --- a/arch/um/drivers/vector_kern.c
> > +++ b/arch/um/drivers/vector_kern.c
> > @@ -1156,8 +1156,10 @@ static int vector_net_open(struct net_device *dev)
> >
> > struct vector_device *vdevice;
> >
> > spin_lock_irqsave(&vp->lock, flags);
> >
> > - if (vp->opened)
> > + if (vp->opened) {
> > + spin_unlock_irqrestore(&vp->lock, flags);
> >
> > return -ENXIO;
> >
> > + }
> >
> > vp->opened = true;
> > spin_unlock_irqrestore(&vp->lock, flags);
Please review/ack these patches.
Thanks,
//richard
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
next parent reply other threads:[~2017-12-11 9:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171209114940.fsi7jbxd7zbhhu74@mwanda>
[not found] ` <54b3ee94-6afd-7907-3764-e2413f231209@cambridgegreys.com>
2017-12-11 9:33 ` Richard Weinberger [this message]
2017-12-11 9:36 ` [uml-devel] [PATCH 1/2] um: vector_kern: Unlock on error in vector_net_open() Anton Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3254171.LO6pLlHuPk@blindfold \
--to=richard@nod.at \
--cc=anton.ivanov@cambridgegreys.com \
--cc=dan.carpenter@oracle.com \
--cc=jdike@addtoit.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=user-mode-linux-user@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox