From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1W2Of1-0008Q1-Ni for user-mode-linux-devel@lists.sourceforge.net; Sun, 12 Jan 2014 17:17:19 +0000 Received: from b.ns.miles-group.at ([95.130.255.144] helo=radon.swed.at) by sog-mx-4.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) id 1W2Of0-0006YU-5U for user-mode-linux-devel@lists.sourceforge.net; Sun, 12 Jan 2014 17:17:19 +0000 From: Richard Weinberger Date: Sun, 12 Jan 2014 18:17:06 +0100 Message-ID: <3356484.sS3LQGJdk9@sandpuppy> In-Reply-To: <52D2CA8E.7090707@zytor.com> References: <20140112120305.GA13076@gmail.com> <1389538341-31383-1-git-send-email-richard@nod.at> <52D2CA8E.7090707@zytor.com> MIME-Version: 1.0 List-Id: The user-mode Linux development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: user-mode-linux-devel-bounces@lists.sourceforge.net Subject: Re: [uml-devel] [PATCH] um, x86: Fix vDSO build To: "H. Peter Anvin" Cc: user-mode-linux-devel@lists.sourceforge.net, linux-tip-commits@vger.kernel.org, paul.gortmaker@windriver.com, mingo@redhat.com, tglx@linutronix.de, Fengguang Wu Am Sonntag, 12. Januar 2014, 09:02:06 schrieb H. Peter Anvin: > On 01/12/2014 06:52 AM, Richard Weinberger wrote: > > Commit "x86: Delete non-required instances of include " > > broke the UML build. > > > > arch/x86/um/vdso/vdso.S: Assembler messages: > > arch/x86/um/vdso/vdso.S:2: Error: no such instruction: `__initdata' > > arch/x86/um/vdso/vdso.S:9: Error: no such instruction: `__finit' > > > > UML's vDSO needs linux/init.h. > > > > Signed-off-by: Richard Weinberger > > --- > > > > arch/x86/um/vdso/vdso.S | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/x86/um/vdso/vdso.S b/arch/x86/um/vdso/vdso.S > > index 4b4bd4c..1cb468a 100644 > > --- a/arch/x86/um/vdso/vdso.S > > +++ b/arch/x86/um/vdso/vdso.S > > @@ -1,3 +1,4 @@ > > +#include > > > > __INITDATA > > So more bits that got "cleaned up" but never actually tested. Sigh. > > Fengguang, could we get UM builds added to the test robot? Would be great! Fengguang, please make sure that you build both UML/i386 and UML/x86_64. i.e. make defconfig ARCH=um SUBARCH=i386 && make linux ARCH=um and make defconfig ARCH=um SUBARCH=x86 && make linux ARCH=um Thanks, //richard ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel