From: Johannes Berg <johannes@sipsolutions.net>
To: anton.ivanov@cambridgegreys.com, linux-um@lists.infradead.org
Cc: richard@nod.at
Subject: Re: [PATCH 1/3] um: Monitor error events in IRQ controller
Date: Mon, 07 Dec 2020 18:35:51 +0100 [thread overview]
Message-ID: <3904ecc6b329edc1af908f7701bc08fb18316fff.camel@sipsolutions.net> (raw)
In-Reply-To: <20201207171940.25240-1-anton.ivanov@cambridgegreys.com>
On Mon, 2020-12-07 at 17:19 +0000, anton.ivanov@cambridgegreys.com
wrote:
> From: Anton Ivanov <anton.ivanov@cambridgegreys.com>
>
> Ensure that file closes, connection closes, etc are propagated
> as interrupts in the interrupt controller.
>
> Fixes: ff6a17989c08 ("Epoll based IRQ controller")
> Signed-off-by: Anton Ivanov <anton.ivanov@cambridgegreys.com>
> ---
> arch/um/os-Linux/irq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/um/os-Linux/irq.c b/arch/um/os-Linux/irq.c
> index d508310ee5e1..f1732c308c61 100644
> --- a/arch/um/os-Linux/irq.c
> +++ b/arch/um/os-Linux/irq.c
> @@ -48,7 +48,7 @@ int os_epoll_triggered(int index, int events)
> int os_event_mask(int irq_type)
> {
> if (irq_type == IRQ_READ)
> - return EPOLLIN | EPOLLPRI;
> + return EPOLLIN | EPOLLPRI | EPOLLERR | EPOLLHUP | EPOLLRDHUP;
> if (irq_type == IRQ_WRITE)
> return EPOLLOUT;
Why not monitor it also for write?
johannes
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2020-12-07 17:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 17:19 [PATCH 1/3] um: Monitor error events in IRQ controller anton.ivanov
2020-12-07 17:19 ` [PATCH 2/3] um: tty: Fix handling of close in tty lines anton.ivanov
2020-12-07 17:19 ` [PATCH 3/3] um: chan_xterm: Fix fd leak anton.ivanov
2020-12-07 17:35 ` Johannes Berg [this message]
2020-12-07 18:11 ` [PATCH 1/3] um: Monitor error events in IRQ controller Anton Ivanov
2020-12-09 17:49 ` Anton Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3904ecc6b329edc1af908f7701bc08fb18316fff.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=anton.ivanov@cambridgegreys.com \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox