From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lithops.sigma-star.at ([195.201.40.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gByQI-000878-3r for linux-um@lists.infradead.org; Mon, 15 Oct 2018 08:40:26 +0000 From: Richard Weinberger Subject: Re: [PATCH, RFC] ubd: remove use of blk_rq_map_sg Date: Mon, 15 Oct 2018 10:40:06 +0200 Message-ID: <4055590.4i3nx3fRmo@blindfold> In-Reply-To: <20181015065637.1860-1-hch@lst.de> References: <20181015065637.1860-1-hch@lst.de> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Christoph Hellwig Cc: axboe@kernel.dk, linux-block@vger.kernel.org, linux-um@lists.infradead.org, anton.ivanov@cambridgegreys.com Christoph, [CC'ing also Anton, he improved the old driver a lot.] Anton, this patch is based on: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/?h=mq-conversions Am Montag, 15. Oktober 2018, 08:56:37 CEST schrieb Christoph Hellwig: > There is no good reason to create a scatterlist in the ubd driver, > it can just iterate the request directly. > > Signed-off-by: Christoph Hellwig > --- > > Now that we have the blk-mq conversion something like the patch below > should help to simplify the driver even further. hm, this breaks UML. Every filesystem fails to mount. I did some very rough tests, it seems that the driver fails to read data correctly as soon the upper layer tries to get more than 4096 bytes at once out of the block device. IOW: dd if=/dev/ubda bs=4096 count=1 skip=0 2>/dev/null| md5sum - is good. As soon I set bs to something greater it returns garbage. Later this day I might have some cycles left to debug further. Thanks, //richard _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um