From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C22F0FD9E0A for ; Thu, 26 Feb 2026 21:45:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:References:In-Reply-To:Message-ID:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0IoW2lvrXsjb3iAXC2/BQDLTRJdTcFAm/Q7tz8IzCp4=; b=PmW8xwm5N0s1Bg6QLR9qAf+Z/M UCsMOwe4z1Z84CGKxYjhT++6loHRonKfBtfgoV9p9Q6ICqvthCozkCcdJOEQLzdov58MKec3/PAcl 0SUI/k8erW8Rv+ORCUkpLWd8RRYkZ3z3RTmBsWwaFFNP0Ypn2Dl46CRlSPwUuTdLVAuA07vcFA8Dc lDeM60ubtqivIU4Jn6Qi7/K3mQmz9V5zlDB3k4wJJcZ/Rnv+sEkxoWNeZrtrat/crI6GZgR10/atD pWwr3oYXaMHDGBkT8/h/iTse2npaqR32I8yVhl1T5YGHwDNNiwzrCNpXgw5FmFPrQT+0DMRN8QTfX mGvRvBhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vvjAt-00000007GOI-2r09; Thu, 26 Feb 2026 21:45:35 +0000 Received: from mailout.nod.at ([116.203.167.152] helo=lithops.sigma-star.at) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vvjAq-00000007GMQ-0tIR; Thu, 26 Feb 2026 21:45:33 +0000 Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 0B325298599; Thu, 26 Feb 2026 22:45:29 +0100 (CET) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id vJnDbvqv8fxU; Thu, 26 Feb 2026 22:45:28 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id E98F629859D; Thu, 26 Feb 2026 22:45:27 +0100 (CET) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id jjhkwk3e1cfi; Thu, 26 Feb 2026 22:45:27 +0100 (CET) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id 2545C298580; Thu, 26 Feb 2026 22:45:27 +0100 (CET) Date: Thu, 26 Feb 2026 22:45:26 +0100 (CET) From: Richard Weinberger To: hch Cc: Andrew Morton , Richard Henderson , Matt Turner , Magnus Lindholm , Russell King , Catalin Marinas , will , Huacai Chen , WANG Xuerui , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , davem , Andreas Larsson , anton ivanov , Johannes Berg , Thomas Gleixner , mingo , bp , dave hansen , x86 , hpa , Herbert Xu , dan j williams , Chris Mason , David Sterba , Arnd Bergmann , Song Liu , Yu Kuai , Li Nan , linux-alpha , linux-kernel , linux-arm-kernel , loongarch , linuxppc-dev , linux-riscv , linux-s390 , sparclinux , linux-um , Linux Crypto Mailing List , linux-btrfs , linux-arch , linux-raid Message-ID: <445921547.2198.1772142326749.JavaMail.zimbra@nod.at> In-Reply-To: <20260226151106.144735-4-hch@lst.de> References: <20260226151106.144735-1-hch@lst.de> <20260226151106.144735-4-hch@lst.de> Subject: Re: [PATCH 03/25] um/xor: don't override XOR_SELECT_TEMPLATE MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [195.201.40.130] X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF147 (Linux)/8.8.12_GA_3809) Thread-Topic: um/xor: don't override XOR_SELECT_TEMPLATE Thread-Index: geHUNAwCPFDc7iDnvkYlaCznwUsWXw== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260226_134532_625096_7B42F886 X-CRM114-Status: UNSURE ( 6.76 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org ----- Urspr=C3=BCngliche Mail ----- > Von: "hch" > XOR_SELECT_TEMPLATE is only ever called with a NULL argument, so all the > ifdef'ery doesn't do anything. With our without this, the time travel > mode should work fine on CPUs that support AVX2, as the AVX2 > implementation is forced in this case, and won't work otherwise. IIRC Johannes added XOR_SELECT_TEMPLATE() here to skip the template selection logic because it didn't work with time travel mode. Johannes, can you please test whether this change does not break time travel mode? Thanks, //richard