Re: [uml-devel] ARCH=um SUBARCH=i386 breakage?

[Antoine Martin <antoine@nagafix.co.uk>]

Jeff Dike wrote:
> On Fri, Jul 13, 2007 at 01:03:21PM +0100, Antoine Martin wrote:
>   
>> I had updated the kernel headers and these include files have been removed.
>> Until UML uses some other trick, this works for me for the 64-bit build:
>>
>> cp /usr/src/linux-2.6.22.1/include/asm/user.h /usr/include/asm/user.h
>> cp /usr/src/linux-2.6.22.1/include/asm/page.h /usr/include/asm/page.h
>> cp /usr/src/linux-2.6.22.1/include/linux/const.h /usr/include/linux/const.h
>>     
>
> asm/user,h looks like a problem.  The only other way I see to get the
> size of the FP registers is elf_fpregset_t and elf_fpxregset_t in
> asm/elf.h, which is exported.  However, those are defined in terms of
> user_i387_struct and user_fxsr_struct in user.h, and it gets them with
>
> 	#include <asm/user.h>
>
> So, we seem to have a situation where an exported header includes a
> non-exported one, or the include is filtered out and we have a type
> with an unknown size.
>
> Could you check this there by seeing if something like this builds
> (with user.h removed):
>
> #include <asm/elf.h>
>
> int main(void){
> 	printf("%d %d\n", sizeof(elf_fpregset_t), sizeof(elf_fpxregset_t));
>   
My kernel headers are also missing elf.h, so this doesn't work either...

It is included in page.h:

  CC      arch/um/sys-i386/user-offsets.s
In file included from /usr/include/asm/user.h:5,
                 from arch/um/sys-i386/user-offsets.c:7:
/usr/include/asm/page.h:4:25: error: linux/const.h: No such file or 
directory
arch/um/sys-i386/user-offsets.c: In function 'foo':
arch/um/sys-i386/user-offsets.c:52: error: invalid application of 
'sizeof' to incomplete type 'struct user_fxsr_struct'
make[1]: *** [arch/um/sys-i386/user-offsets.s] Error 1
make: *** [arch/um/sys-i386/user-offsets.s] Error 2

> Can you get rid of page.h and const.h (you'll have to leave user.h
> unfortunately) again and try the patch below?  It builds for me on
> both i386 and x86_64.
>   
I get the same error as above because user.h includes  asm/page.h
I tried removing the include from user.h, but then I get:
  CC      arch/um/sys-i386/user-offsets.s
arch/um/sys-i386/user-offsets.c: In function 'foo':
arch/um/sys-i386/user-offsets.c:52: error: invalid application of 
'sizeof' to incomplete type 'struct user_fxsr_struct'
make[1]: *** [arch/um/sys-i386/user-offsets.s] Error 1
make: *** [arch/um/sys-i386/user-offsets.s] Error 2


Antoine


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel