From: Johannes Berg <johannes@sipsolutions.net>
To: Tiwei Bie <tiwei.btw@antgroup.com>,
richard@nod.at, anton.ivanov@cambridgegreys.com
Cc: linux-um@lists.infradead.org
Subject: Re: [PATCH v3 4/4] um: Prohibit the VM_CLONE flag in run_helper_thread()
Date: Thu, 20 Mar 2025 09:32:31 +0100 [thread overview]
Message-ID: <495e4b66edcc65ba9630cf1bbbb119b971af2df6.camel@sipsolutions.net> (raw)
In-Reply-To: <20250319135523.97050-5-tiwei.btw@antgroup.com>
On Wed, 2025-03-19 at 21:55 +0800, Tiwei Bie wrote:
> Directly creating helper threads with VM_CLONE using clone can
> compromise the thread safety of errno. Since all these helper
> threads have been converted to use os_run_helper_thread(), let's
> prevent using this flag in run_helper_thread().
>
I notice that now there's only one user left, the SIGWINCH handler,
maybe we could change that too? Anyway not related to this patch, of
course.
johannes
next prev parent reply other threads:[~2025-03-20 8:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 13:55 [PATCH v3 0/4] um: Make errno multi-thread safe Tiwei Bie
2025-03-19 13:55 ` [PATCH v3 1/4] um: Add pthread-based helper support Tiwei Bie
2025-03-19 13:55 ` [PATCH v3 2/4] um: ubd: Switch to the pthread-based helper Tiwei Bie
2025-03-19 13:55 ` [PATCH v3 3/4] um: Switch to the pthread-based helper in sigio workaround Tiwei Bie
2025-03-19 13:55 ` [PATCH v3 4/4] um: Prohibit the VM_CLONE flag in run_helper_thread() Tiwei Bie
2025-03-20 8:32 ` Johannes Berg [this message]
2025-03-20 14:42 ` Tiwei Bie
2025-03-26 6:54 ` Tiwei Bie
2025-03-26 7:13 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=495e4b66edcc65ba9630cf1bbbb119b971af2df6.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=anton.ivanov@cambridgegreys.com \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
--cc=tiwei.btw@antgroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox