From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <4F956DF2.7020408@nod.at> Date: Mon, 23 Apr 2012 16:57:54 +0200 From: Richard Weinberger MIME-Version: 1.0 References: <20120423070641.GA27702@lizard> <20120423070925.GG30752@lizard> In-Reply-To: <20120423070925.GG30752@lizard> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Subject: Re: [PATCH 7/9] um: Should hold tasklist_lock while traversing processes To: Anton Vorontsov Cc: Andrew Morton , Oleg Nesterov , Russell King , Mike Frysinger , Benjamin Herrenschmidt , Paul Mundt , Peter Zijlstra , KOSAKI Motohiro , John Stultz , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, uclinux-dist-devel@blackfin.uclinux.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net, linaro-kernel@lists.linaro.org, patches@linaro.org, linux-mm@kvack.org List-ID: On 23.04.2012 09:09, Anton Vorontsov wrote: > Traversing the tasks requires holding tasklist_lock, otherwise it > is unsafe. > > p.s. However, I'm not sure that calling os_kill_ptraced_process() > in the atomic context is correct. It seem to work, but please > take a closer look. > > Signed-off-by: Anton Vorontsov > --- You forgot my Ack and I've already explained why os_kill_ptraced_process() is fine. Thanks, //richard