From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Kyle Huey" <me@kylehuey.com>,
"Robert O'Callahan" <robert@ocallahan.org>,
"Andy Lutomirski" <luto@kernel.org>,
"Ingo Molnar" <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, "Radim Krčmář" <rkrcmar@redhat.com>,
"Jeff Dike" <jdike@addtoit.com>,
"Richard Weinberger" <richard@nod.at>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Shuah Khan" <shuah@kernel.org>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Borislav Petkov" <bp@suse.de>,
"Peter Zijlstra" <peterz@infradead.org>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
"Len Brown" <len.brown@intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Dmitry Safonov" <dsafonov@virtuozzo.com>,
linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [PATCH v8 7/7] KVM: x86: virtualize cpuid faulting
Date: Tue, 1 Nov 2016 23:51:46 +0100 [thread overview]
Message-ID: <4b51938b-aa81-6bc5-2d66-0ef8c17dafdf@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1611011233100.14687@nanos>
On 01/11/2016 19:33, Thomas Gleixner wrote:
> On Tue, 1 Nov 2016, Paolo Bonzini wrote:
>
>>
>>> + vcpu->arch.cpuid_fault = false;
>>
>> This should be conditional on "if (!init_event)". Most MSRs are untouched
>> on an INIT IPI.
>>
>> Otherwise looks good. The patch is independent of the rest, so I would
>> prefer to take it through the KVM tree.
>>
>
> It depends on the FEATURE_ENABLES MSR define, which is part of that series.
Sure, I usually time my pull request anyway so that generic arch stuff
goes in first (KVM comes after architectures in linux-next, too). If
only the first 6 patches are included in tip, I can handle the seventh
myself.
Paolo
next prev parent reply other threads:[~2016-11-01 22:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 1:37 [PATCH v8 0/7] x86/arch_prctl Add ARCH_[GET|SET]_CPUID for controlling the CPUID instruction Kyle Huey
2016-11-01 1:37 ` [PATCH v8 1/7] x86/arch_prctl/64: Use SYSCALL_DEFINE2 to define sys_arch_prctl Kyle Huey
2016-11-01 1:37 ` [PATCH v8 2/7] x86/arch_prctl/64: Rename do_arch_prctl to do_arch_prctl_64 Kyle Huey
2016-11-01 1:37 ` [PATCH v8 3/7] x86/arch_prctl: Add do_arch_prctl_common Kyle Huey
2016-11-01 1:37 ` [PATCH v8 4/7] x86/syscalls/32: Wire up arch_prctl on x86-32 Kyle Huey
2016-11-01 1:37 ` [PATCH v8 5/7] x86/cpufeature: Detect CPUID faulting support Kyle Huey
2016-11-01 1:37 ` [PATCH v8 6/7] x86/arch_prctl: Add ARCH_[GET|SET]_CPUID Kyle Huey
2016-11-01 1:37 ` [PATCH v8 7/7] KVM: x86: virtualize cpuid faulting Kyle Huey
2016-11-01 14:26 ` Paolo Bonzini
2016-11-01 18:33 ` Thomas Gleixner
2016-11-01 22:51 ` Paolo Bonzini [this message]
2016-11-04 20:34 ` David Matlack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b51938b-aa81-6bc5-2d66-0ef8c17dafdf@redhat.com \
--to=pbonzini@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@suse.de \
--cc=dave.hansen@linux.intel.com \
--cc=dsafonov@virtuozzo.com \
--cc=hpa@zytor.com \
--cc=jdike@addtoit.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=me@kylehuey.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=richard@nod.at \
--cc=rkrcmar@redhat.com \
--cc=robert@ocallahan.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).