From: "H. Peter Anvin" <hpa@zytor.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
deller@gmx.de, Andrew Morton <akpm@linux-foundation.org>,
"Eric W . Biederman" <ebiederm@xmission.com>,
Thomas Gleixner <tglx@linutronix.de>,
mingo@redhat.com, Simon Horman <horms@verge.net.au>,
Nathan Chancellor <natechancellor@gmail.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Greg KH <gregkh@linuxfoundation.org>,
rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com,
vgupta@synopsys.com, linux@armlinux.org.uk,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
msalter@redhat.com, jacquiot.aurelien@gmail.com,
Yoshinori Sato <ysato@users.sourceforge.jp>,
rkuo@codeaurora.org, tony.luck@intel.com, fenghua.yu@intel.com,
Geert Uytterhoeven <geert@linux-m68k.org>,
monstr@monstr.eu, ralf@linux-mips.org, paul.burton@mips.com,
jhogan@kernel.org, green.hu@gmail.com, deanbo422@gmail.com,
lftan@altera.com, jonas@southpole.se,
stefan.kristiansson@saunalahti.fi,
Stafford Horne <shorne@gmail.com>,
jejb@parisc-linux.org, benh@kernel.crashing.org,
paulus@samba.org, mpe@ellerman.id.au, palmer@sifive.com,
aou@eecs.berkeley.edu, schwidefsky@de.ibm.com,
heiko.carstens@de.ibm.com, dalias@libc.org,
"David S. Miller" <davem@davemloft.net>,
gxt@pku.edu.cn, x86@kernel.org, jdike@addtoit.com,
richard@nod.at, chris@zankel.net, jcmvbkbc@gmail.com,
Tobias Klauser <tklauser@distanz.ch>,
noamc@ezchip.com, mickael.guene@st.com, nicolas.pitre@linaro.org,
Kees Cook <keescook@chromium.org>,
Dave Martin <Dave.Martin@arm.com>,
Marc Zyngier <marc.zyngier@arm.com>,
alex.bennee@linaro.org, Laura Abbott <labbott@redhat.com>,
Yury Norov <ynorov@caviumnetworks.com>,
Mark Rutland <mark.rutland@arm.com>,
chenhc@lemote.com, macro@mips.com, Arnd Bergmann <arnd@arndb.de>,
dhowells@redhat.com, sukadev@linux.vnet.ibm.com,
Nicholas Piggin <npiggin@gmail.com>,
aneesh.kumar@linux.vnet.ibm.com, felix@linux.vnet.ibm.com,
linuxram@us.ibm.com, christophe.leroy@c-s.fr, cohuck@redhat.com,
gor@linux.vnet.ibm.com, nick.alcock@oracle.com,
shannon.nelson@oracle.com, nagarathnam.muthusamy@oracle.com,
luto@kernel.org, bp@suse.de, dave.hansen@linux.intel.com,
vkuznets@redhat.com, jkosina@suse.cz,
linux-alpha@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-snps-arc@lists.infradead.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-c6x-dev@linux-c6x.org,
uclinux-h8-devel@lists.sourceforge.jp,
linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-m68k@vger.kernel.org, linux-mips@linux-mips.org,
nios2-dev@lists.rocketboards.org, openrisc@lists.librecores.org,
linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
linux-um@lists.infradead.org
Subject: Re: [PATCH] treewide: remove current_text_addr
Date: Mon, 27 Aug 2018 06:33:27 -0700 [thread overview]
Message-ID: <4d1a8f35-e2fc-70d2-ca0e-44b8574c86f1@zytor.com> (raw)
In-Reply-To: <20180827131103.GD24124@hirez.programming.kicks-ass.net>
On 08/27/18 06:11, Peter Zijlstra wrote:
> On Mon, Aug 27, 2018 at 05:26:53AM -0700, H. Peter Anvin wrote:
>
>> _THIS_IP_, however, is completely ill-defined, other than being an
>> address *somewhere* in the same global function (not even necessarily
>> the same function if the function is static!) As my experiment show, in
>> many (nearly) cases gcc will hoist the address all the way to the top of
>> the function, at least for the current generic implementation.
>
> It seems to have mostly worked so far... did anything change?
>
Most likely because the major architectures contain a arch-specific
assembly implementation. The generic implementation used in some places
is completely broken, as my experiments show.
>> For the case where _THIS_IP_ is passed to an out-of-line function in all
>> cases, it is extra pointless because all it does is increase the
>> footprint of every caller: _RET_IP_ is inherently passed to the function
>> anyway, and with tailcall protection it will uniquely identify a callsite.
>
> So I think we can convert many of the lockdep _THIS_IP_ calls to
> _RET_IP_ on the other side, with a wee bit of care.
>
> A little something like so perhaps...
I don't have time to look at this right now (I'm on sabbatical, and I'm
dealing with personal legal stuff right at the moment), but I think it
is the right direction.
-hpa
next prev parent reply other threads:[~2018-08-27 13:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAKwvOdkWL_2yTnJqM6n6R9UCPwY4iz-9BQYGN2MDAk9EzumUvA@mail.gmail.com>
2018-08-21 20:28 ` [PATCH] treewide: remove current_text_addr Nick Desaulniers
2018-08-25 10:48 ` Helge Deller
2018-08-26 2:38 ` H. Peter Anvin
2018-08-26 3:16 ` H. Peter Anvin
2018-08-26 4:56 ` H. Peter Anvin
2018-08-26 19:30 ` H. Peter Anvin
2018-08-26 20:25 ` Linus Torvalds
2018-08-27 2:52 ` Nick Desaulniers
2018-08-27 7:33 ` Peter Zijlstra
2018-08-27 12:26 ` H. Peter Anvin
2018-08-27 13:11 ` Peter Zijlstra
2018-08-27 13:33 ` H. Peter Anvin [this message]
2018-08-31 16:48 ` Nick Desaulniers
2018-08-27 7:43 ` Nicholas Piggin
2018-08-26 23:20 ` H. Peter Anvin
2018-08-25 21:02 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d1a8f35-e2fc-70d2-ca0e-44b8574c86f1@zytor.com \
--to=hpa@zytor.com \
--cc=Dave.Martin@arm.com \
--cc=akpm@linux-foundation.org \
--cc=alex.bennee@linaro.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=bp@suse.de \
--cc=catalin.marinas@arm.com \
--cc=chenhc@lemote.com \
--cc=chris@zankel.net \
--cc=christophe.leroy@c-s.fr \
--cc=cohuck@redhat.com \
--cc=dalias@libc.org \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=deanbo422@gmail.com \
--cc=deller@gmx.de \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=felix@linux.vnet.ibm.com \
--cc=fenghua.yu@intel.com \
--cc=geert@linux-m68k.org \
--cc=gor@linux.vnet.ibm.com \
--cc=green.hu@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gxt@pku.edu.cn \
--cc=heiko.carstens@de.ibm.com \
--cc=horms@verge.net.au \
--cc=ink@jurassic.park.msu.ru \
--cc=jacquiot.aurelien@gmail.com \
--cc=jcmvbkbc@gmail.com \
--cc=jdike@addtoit.com \
--cc=jejb@parisc-linux.org \
--cc=jhogan@kernel.org \
--cc=jkosina@suse.cz \
--cc=jonas@southpole.se \
--cc=keescook@chromium.org \
--cc=kstewart@linuxfoundation.org \
--cc=labbott@redhat.com \
--cc=lftan@altera.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-c6x-dev@linux-c6x.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-um@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=linuxram@us.ibm.com \
--cc=luto@kernel.org \
--cc=macro@mips.com \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mattst88@gmail.com \
--cc=mickael.guene@st.com \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=mpe@ellerman.id.au \
--cc=msalter@redhat.com \
--cc=nagarathnam.muthusamy@oracle.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=nick.alcock@oracle.com \
--cc=nicolas.pitre@linaro.org \
--cc=nios2-dev@lists.rocketboards.org \
--cc=noamc@ezchip.com \
--cc=npiggin@gmail.com \
--cc=openrisc@lists.librecores.org \
--cc=palmer@sifive.com \
--cc=paul.burton@mips.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=pombredanne@nexb.com \
--cc=ralf@linux-mips.org \
--cc=richard@nod.at \
--cc=rkuo@codeaurora.org \
--cc=rth@twiddle.net \
--cc=schwidefsky@de.ibm.com \
--cc=shannon.nelson@oracle.com \
--cc=shorne@gmail.com \
--cc=sparclinux@vger.kernel.org \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=sukadev@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=tklauser@distanz.ch \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=uclinux-h8-devel@lists.sourceforge.jp \
--cc=vgupta@synopsys.com \
--cc=vkuznets@redhat.com \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
--cc=ynorov@caviumnetworks.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox