From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <53ED36AB.8020703@gmail.com> Date: Fri, 15 Aug 2014 06:22:35 +0800 From: Chen Gang MIME-Version: 1.0 References: <53ECE9DD.80004@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v3] arch: Kconfig: Let all architectures set endian explicitly To: Lennox Wu Cc: Vineet Gupta , Arnd Bergmann , "akpm@linux-foundation.org" , "rth@twiddle.net" , "ink@jurassic.park.msu.ru" , "mattst88@gmail.com" , Geert Uytterhoeven , Jean Delvare , "linux@arm.linux.org.uk" , "catalin.marinas@arm.com" , "will.deacon@arm.com" , "hskinnemoen@gmail.com" , "egtvedt@samfundet.no" , "realmz6@gmail.com" , "msalter@redhat.com" , "a-jacquiot@ti.com" , "starvik@axis.com" , "jesper.nilsson@axis.com" , "dhowells@redhat.com" , "rkuo@codeaurora.org" , "tony.luck@intel.com" , "fenghua.yu@intel.com" , "takata@linux-m32r.org" , "james.hogan@imgtec.com" , Michal Simek , "ralf@linux-mips.org" , "yasutake.koichi@jp.panasonic.com" , "jonas@southpole.se" , "jejb@parisc-linux.org" , "deller@gmx.de" , Benjamin Herrenschmidt , "paulus@samba.org" , "mpe@ellerman.id.au" , Martin Schwidefsky , "heiko.carstens@de.ibm.com" , Liqin Chen , "David S. Miller" , "cmetcalf@tilera.com" , "jdike@addtoit.com" , Richard Weinberger , "gxt@mprc.pku.edu.cn" , "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "chris@zankel.net" , "jcmvbkbc@gmail.com" , "linux390@de.ibm.com" , "x86@kernel.org" , "linux-alpha@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "adi-buildroot-devel@lists.sourceforge.net" , "linux-c6x-dev@linux-c6x.org" , "linux-cris-kernel@axis.com" , "linux-hexagon@vger.kernel.org" , "linux-ia64@vger.kernel.org" , "linux-m32r@ml.linux-m32r.org" , "linux-m32r-ja@ml.linux-m32r.org" , "linux-m68k@lists.linux-m68k.org" , "linux-metag@vger.kernel.org" , "linux-mips@linux-mips.org" , "linux-am33-list@redhat.com" , "linux@lists.openrisc.net" , "linux-parisc@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-s390@vger.kernel.org" , "sparclinux@vger.kernel.org" , "user-mode-linux-devel@lists.sourceforge.net" , "user-mode-linux-user@lists.sourceforge.net" , "linux-xtensa@linux-xtensa.org" List-ID: On 08/15/2014 02:27 AM, Lennox Wu wrote: > I don't think it's necessary, what's the benfit? > > 2014-08-15 2:21 GMT+08:00 Vineet Gupta : > >> On Thursday 14 August 2014 09:55 AM, Chen Gang wrote: [...] >>> diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig >>> index 9596b0a..e939abd 100644 >>> --- a/arch/arc/Kconfig >>> +++ b/arch/arc/Kconfig >>> @@ -35,6 +35,7 @@ config ARC >>> select OF_EARLY_FLATTREE >>> select PERF_USE_VMALLOC >>> select HAVE_DEBUG_STACKOVERFLOW >>> + select CPU_LITTLE_ENDIAN if !CPU_BIG_ENDIAN >> >> It is not clear what exactly are you trying to fix. What doesn't work w/o >> this >> patch ! >> For many individual modules may need check CPU_LITTLE_ENDIAN or CPU_BIG_ENDIAN, which is an architecture's attribute. Or they have to list many architectures which they support, which they don't support. And still, it is not precise. For architecture API, endian is a main architecture's attribute which may be used by outside, so every architecture need let outside know about it, explicitly. Thanks. -- Chen Gang Open share and attitude like air water and life which God blessed