From: Vegard Nossum <vegard.nossum@oracle.com>
To: Richard Weinberger <richard@nod.at>
Cc: Al Viro <viro@zeniv.linux.org.uk>, Jeff Dike <jdike@addtoit.com>,
user-mode-linux-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uml: fix hostfs mknod()
Date: Wed, 16 Dec 2015 23:21:14 +0100 [thread overview]
Message-ID: <5671E3DA.3010506@oracle.com> (raw)
In-Reply-To: <5671E30A.8030207@nod.at>
On 12/16/2015 11:17 PM, Richard Weinberger wrote:
> Am 16.12.2015 um 21:59 schrieb Vegard Nossum:
>> An inverted return value check in hostfs_mknod() caused the function
>> to return success after handling it as an error (and cleaning up).
>>
[...]
>
> Applied! :-)
>
> BTW: How did you create this patch? I had to apply it by hand using -p0...
> git am didn't like it.
Ah, sorry, I have diff.noprefix=true since I like to double click on
filenames in a diff (there's probably a way to configure the selection
to skip '[ab]/' prefixes when you do that but this was easier). git am
-p0 should work too.
Thanks!
Vegard
prev parent reply other threads:[~2015-12-16 22:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 20:59 [PATCH] uml: fix hostfs mknod() Vegard Nossum
2015-12-16 22:17 ` Richard Weinberger
2015-12-16 22:21 ` Vegard Nossum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5671E3DA.3010506@oracle.com \
--to=vegard.nossum@oracle.com \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).