From: Richard Weinberger <richard@nod.at>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: user-mode-linux-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] um: Fix get_signal() usage
Date: Sat, 9 Jan 2016 10:52:05 +0100 [thread overview]
Message-ID: <5690D845.5090308@nod.at> (raw)
In-Reply-To: <20160109035125.GA365@ZenIV.linux.org.uk>
Am 09.01.2016 um 04:51 schrieb Al Viro:
> On Wed, Nov 18, 2015 at 09:51:43AM +0100, Richard Weinberger wrote:
>> If get_signal() returns us a signal to post
>> we must not call it again, otherwise the already
>> posted signal will be overridden.
>> Before commit a610d6e672d this was the case as we stopped
>> the while after a successful handle_signal().
>
> Old behaviour had been wrong. If you have several pending signals,
> more than one sigframe should be built, as if the second, etc. had
> been delivered right on the entry into the handler.
>
> Stopping after the first one is obviously wrong - consider the case
> when attempt to deliver it has raised SIGSEGV.
You are right. Thanks for pointing this out.
Will revert.
Thanks,
//richard
prev parent reply other threads:[~2016-01-09 9:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 8:51 [PATCH] um: Fix get_signal() usage Richard Weinberger
2016-01-09 3:51 ` Al Viro
2016-01-09 4:09 ` [uml-devel] " Al Viro
2016-01-09 9:52 ` Richard Weinberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5690D845.5090308@nod.at \
--to=richard@nod.at \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).