Re: [uml-devel] [PATCH 02/21] usb: add HAS_IOMEM dependency to USB_NET2272

[Vegard Nossum <vegard.nossum@oracle.com>]

On 02/10/2016 05:15 PM, Greg Kroah-Hartman wrote:
> On Wed, Feb 10, 2016 at 03:29:37PM +0100, Vegard Nossum wrote:
>> drivers/usb/gadget/udc/net2272.c: In function ‘net2272_remove’:
>> drivers/usb/gadget/udc/net2272.c:2232:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>>    iounmap(dev->base_addr);
>>    ^
>> drivers/usb/gadget/udc/net2272.c: In function ‘net2272_plat_probe’:
>> drivers/usb/gadget/udc/net2272.c:2650:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]
>>    dev->base_addr = ioremap_nocache(base, len);
>>    ^
>> drivers/usb/gadget/udc/net2272.c:2650:17: warning: assignment makes pointer from integer without a cast [enabled by default]
>>    dev->base_addr = ioremap_nocache(base, len);
>>                   ^
>>
>> Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
>> ---
>>   drivers/usb/gadget/udc/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig
>> index 753c29b..ca19f6f 100644
>> --- a/drivers/usb/gadget/udc/Kconfig
>> +++ b/drivers/usb/gadget/udc/Kconfig
>> @@ -287,6 +287,7 @@ config USB_FSL_QE
>>   	   dynamically linked module called "fsl_qe_udc".
>>
>>   config USB_NET2272
>> +	depends on HAS_IOMEM
>
> Why not fix the root of the problem and provide the correct functions
> for this when HAS_IOMEM is not enabled?

I don't think there is a "correct function" for when HAS_IOMEM is not
enabled. There is no IO address space on UML, so it doesn't make sense
to compile these drivers in the first place.

Or do you mean to use the dummy implementation from asm-generic/io.h? (I
have to admit I don't know how that would work.)


Vegard

------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel