From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Benjamin Berg <benjamin@sipsolutions.net>
Cc: linux-um@lists.infradead.org, Willy Tarreau <w@1wt.eu>,
linux-kselftest@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>,
linux-kernel@vger.kernel.org, Tiwei Bie <tiwei.btw@antgroup.com>,
Benjamin Berg <benjamin.berg@intel.com>
Subject: Re: [PATCH 3/9] tools/nolibc/stdio: remove perror if NOLIBC_IGNORE_ERRNO is set
Date: Mon, 15 Sep 2025 10:44:03 +0200 [thread overview]
Message-ID: <58366c48-99b6-430a-a05c-51a2a5e044a7@t-8ch.de> (raw)
In-Reply-To: <20250915071115.1429196-4-benjamin@sipsolutions.net>
On 2025-09-15 09:11:09+0200, Benjamin Berg wrote:
> From: Benjamin Berg <benjamin.berg@intel.com>
>
> There is no errno variable when NOLIBC_IGNORE_ERRNO is defined. As such,
> the perror function does not make any sense then and cannot compile.
>
> Fixes: acab7bcdb1bc ("tools/nolibc/stdio: add perror() to report the errno value")
> Signed-off-by: Benjamin Berg <benjamin.berg@intel.com>
Acked-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> tools/include/nolibc/stdio.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/include/nolibc/stdio.h b/tools/include/nolibc/stdio.h
> index 7630234408c5..c512159b8374 100644
> --- a/tools/include/nolibc/stdio.h
> +++ b/tools/include/nolibc/stdio.h
> @@ -597,11 +597,13 @@ int sscanf(const char *str, const char *format, ...)
> return ret;
> }
>
> +#ifndef NOLIBC_IGNORE_ERRNO
> static __attribute__((unused))
> void perror(const char *msg)
> {
> fprintf(stderr, "%s%serrno=%d\n", (msg && *msg) ? msg : "", (msg && *msg) ? ": " : "", errno);
> }
> +#endif
>
> static __attribute__((unused))
> int setvbuf(FILE *stream __attribute__((unused)),
> --
> 2.51.0
>
next prev parent reply other threads:[~2025-09-15 8:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 7:11 [PATCH 0/9] Start porting UML to nolibc Benjamin Berg
2025-09-15 7:11 ` [PATCH 1/9] tools compiler.h: fix __used definition Benjamin Berg
2025-09-15 8:39 ` Thomas Weißschuh
2025-09-15 7:11 ` [PATCH 2/9] um: use tools/include for user files Benjamin Berg
2025-09-15 10:40 ` kernel test robot
2025-09-15 7:11 ` [PATCH 3/9] tools/nolibc/stdio: remove perror if NOLIBC_IGNORE_ERRNO is set Benjamin Berg
2025-09-15 8:44 ` Thomas Weißschuh [this message]
2025-09-15 7:11 ` [PATCH 4/9] tools/nolibc/dirent: avoid errno in readdir_r Benjamin Berg
2025-09-15 8:45 ` Thomas Weißschuh
2025-09-15 7:11 ` [PATCH 5/9] tools/nolibc: use __fallthrough__ rather than fallthrough Benjamin Berg
2025-09-15 8:50 ` Thomas Weißschuh
2025-09-15 7:11 ` [PATCH 6/9] tools/nolibc: add option to disable startup code Benjamin Berg
2025-09-15 8:55 ` Thomas Weißschuh
2025-09-15 7:11 ` [PATCH 7/9] um: add infrastructure to build files using nolibc Benjamin Berg
2025-09-15 8:57 ` Thomas Weißschuh
2025-09-15 7:11 ` [PATCH 8/9] um: use nolibc for the --showconfig implementation Benjamin Berg
2025-09-15 7:11 ` [PATCH 9/9] um: switch ptrace FP register access to nolibc Benjamin Berg
2025-09-15 9:07 ` Thomas Weißschuh
2025-09-15 11:09 ` Berg, Benjamin
2025-09-15 11:22 ` Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58366c48-99b6-430a-a05c-51a2a5e044a7@t-8ch.de \
--to=linux@weissschuh.net \
--cc=acme@redhat.com \
--cc=benjamin.berg@intel.com \
--cc=benjamin@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=tiwei.btw@antgroup.com \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).