From: Daniel Walter <sahne@0x90.at>
To: Thomas Meyer <thomas@m3y3r.de>
Cc: user-mode-linux-devel <user-mode-linux-devel@lists.sourceforge.net>
Subject: Re: [uml-devel] [PATCH v3 3/3] um: enable trace irqflags support
Date: Mon, 20 Oct 2014 11:28:27 +0200 (CEST) [thread overview]
Message-ID: <639004468.1164.1413797307669.JavaMail.root@0x90.at> (raw)
In-Reply-To: <1413731653.2991.24.camel@localhost.localdomain>
----- Original Message -----
> From: "Thomas Meyer" <thomas@m3y3r.de>
> To: "user-mode-linux-devel" <user-mode-linux-devel@lists.sourceforge.net>
> Sent: Sunday, October 19, 2014 4:14:13 PM
> Subject: [uml-devel] [PATCH v3 3/3] um: enable trace irqflags support
>
> Add TRACE_IRQFLAGS_SUPPORT to UML.
> This enables LOCKDEP_SUPPORT and TRACING_SUPPORT.
FYI: I'm currently working on porting ftrace() support to
uml. It will take another week or two since I don't have enough
time to debug, and it isn't stable yet (read as is panic()ing randomly)
>
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> ---
> diff --git a/arch/um/Kconfig.common b/arch/um/Kconfig.common
> index 87bc868..6a33c3a 100644
> --- a/arch/um/Kconfig.common
> +++ b/arch/um/Kconfig.common
> @@ -28,10 +28,9 @@ config PCI
> config PCMCIA
> bool
>
> -# Yet to do!
> config TRACE_IRQFLAGS_SUPPORT
> bool
> - default n
> + default y
>
> config LOCKDEP_SUPPORT
> bool
> diff --git a/arch/um/include/asm/irqflags.h
> b/arch/um/include/asm/irqflags.h
> index c780d8a..c5b636e 100644
> --- a/arch/um/include/asm/irqflags.h
> +++ b/arch/um/include/asm/irqflags.h
> @@ -34,9 +34,9 @@ static inline unsigned long
> arch_local_irq_save(void)
> return flags;
> }
>
> -static inline bool arch_irqs_disabled(void)
> +static inline int arch_irqs_disabled_flags(unsigned long flags)
> {
> - return arch_local_save_flags() == 0;
> + return flags == 0;
> }
>
> #endif
I'm not sure if this is correct. I'd rather would have another function
implemented instead of removing the check for disabled irqs.
cheers,
daniel
------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
next prev parent reply other threads:[~2014-10-20 9:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-19 15:14 [uml-devel] [PATCH v3 3/3] um: enable trace irqflags support Thomas Meyer
2014-10-20 7:15 ` Geert Uytterhoeven
2014-10-20 9:28 ` Daniel Walter [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-10-20 11:18 Thomas Meyer
2014-10-20 12:13 ` Richard Weinberger
2014-10-20 16:14 ` Thomas Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=639004468.1164.1413797307669.JavaMail.root@0x90.at \
--to=sahne@0x90.at \
--cc=thomas@m3y3r.de \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox