From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iGXS6-0002IW-Fv for linux-um@lists.infradead.org; Fri, 04 Oct 2019 23:57:39 +0000 Subject: Re: [PATCH v18 00/19] kunit: introduce KUnit, the Linux kernel unit testing framework References: <20190923090249.127984-1-brendanhiggins@google.com> <20191004213812.GA24644@mit.edu> <56e2e1a7-f8fe-765b-8452-1710b41895bf@kernel.org> <20191004222714.GA107737@google.com> <20191004232955.GC12012@mit.edu> From: shuah Message-ID: <63e59b0b-b51e-01f4-6359-a134a1f903fd@kernel.org> Date: Fri, 4 Oct 2019 17:57:26 -0600 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Brendan Higgins , "Theodore Y. Ts'o" Cc: Petr Mladek , "open list:DOCUMENTATION" , Peter Zijlstra , Amir Goldstein , dri-devel , Sasha Levin , Masahiro Yamada , Michael Ellerman , "open list:KERNEL SELFTEST FRAMEWORK" , Frank Rowand , Rob Herring , linux-nvdimm , Kevin Hilman , Knut Omang , Kieran Bingham , wfg@linux.intel.com, Joel Stanley , David Rientjes , Jeff Dike , Dan Carpenter , devicetree , shuah , Linux Kbuild mailing list , "Bird, Timothy , linux-um@lists.infradead.org, Steven Rostedt" , Julia Lawall , Josh Poimboeuf , kunit-dev@googlegroups.com, Logan Gunthorpe , Richard Weinberger , Stephen Boyd , Greg Kroah-Hartman , Randy Dunlap , Linux Kernel Mailing List , Luis Chamberlain , Daniel Vetter , Kees Cook , linux-fsdevel , Linus Torvalds On 10/4/19 5:52 PM, Brendan Higgins wrote: > On Fri, Oct 4, 2019 at 4:30 PM Theodore Y. Ts'o wrote: >> >> On Fri, Oct 04, 2019 at 04:47:09PM -0600, shuah wrote: >>>> However, if I encourage arbitrary tests/improvements into my KUnit >>>> branch, it further diverges away from torvalds/master, and is more >>>> likely that there will be a merge conflict or issue that is not related >>>> to the core KUnit changes that will cause the whole thing to be >>>> rejected again in v5.5. >>> >>> The idea is that the new development will happen based on kunit in >>> linux-kselftest next. It will work just fine. As we accepts patches, >>> they will go on top of kunit that is in linux-next now. >> >> I don't see how this would work. If I add unit tests to ext4, they >> would be in fs/ext4. And to the extent that I need to add test mocks >> to allow the unit tests to work, they will involve changes to existing >> files in fs/ext4. I can't put them in the ext4.git tree without >> pulling in the kunit changes into the ext4 git tree. And if they ext4 >> unit tests land in the kunit tree, it would be a receipe for large >> numbers of merge conflicts. > > That's where I was originally coming from. > > So here's a dumb idea: what if we merged KUnit through the ext4 tree? > I imagine that could potentially get very confusing when we go back to > sending changes in through the kselftest tree, but at least it means > that ext4 can use it in the meantime, which means that it at least > gets to be useful to one group of people. Also, since Ted seems pretty > keen on using this, I imagine it is much more likely to produce real > world, immediately useful tests not written by me (I'm not being lazy, > I just think it is better to get other people's experiences other than > my own). > That doesn't make sense does it? The tests might not be limited to fs/ext4. We might have other sub-systems that add tests. So, we will have to work to make linux-next as the base for new development and limit the number of tests to where it will be easier work in this mode for 5.5. We can stage the pull requests so that kunit lands first followed by tests. We have a similar situation with kselftest as well. Sub-systems send tests that depend on their tress separately. thanks, -- Shuah _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um