From: stian@nixia.no
To: user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] [PATCH v6] um: Add a high resolution timer subsystem
Date: Tue, 26 May 2015 12:56:14 +0200 [thread overview]
Message-ID: <6c5810675c786f846a68b600d63e46bb@nixia.no> (raw)
In-Reply-To: <5550CE0F.40504@kot-begemot.co.uk>
> nsecs = timer.it_value.tv_sec *
> UM_NSEC_PER_SEC +
> timer.it_value.tv_usec *
> UM_NSEC_PER_USEC;
> nsecs += os_nsecs();
Not looking at the rest of the code, the first thing that comes to my
mind is that this very easy overflows if 32 bit multiplications are used
(tv_sec is usually 32bit and dictates the first multiplication unless
typecast is used).
Stian Skjelstad
------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
next prev parent reply other threads:[~2015-05-26 11:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-09 23:14 [uml-devel] [PATCH v6] um: Add a high resolution timer subsystem Thomas Meyer
2015-05-10 12:35 ` Richard Weinberger
2015-05-10 13:32 ` Anton Ivanov
2015-05-10 14:34 ` Thomas Meyer
2015-05-10 18:25 ` Anton Ivanov
2015-05-10 20:51 ` Richard Weinberger
2015-05-11 12:52 ` Anton Ivanov
2015-05-11 15:05 ` Anton Ivanov
2015-05-11 15:43 ` Anton Ivanov
2015-05-11 17:00 ` Thomas Meyer
2015-05-11 17:20 ` Anton Ivanov
2015-05-11 17:31 ` Anton Ivanov
2015-05-11 17:41 ` Thomas Meyer
2015-05-11 19:42 ` Anton Ivanov
2015-05-11 21:22 ` Thomas Meyer
2015-05-26 10:56 ` stian [this message]
2015-05-11 22:34 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c5810675c786f846a68b600d63e46bb@nixia.no \
--to=stian@nixia.no \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox