From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <6caad65b6229e8e01ce4e125a40f8c1ad2007d39.camel@linux.ibm.com> Subject: Re: [PATCH] parport_pc: Also enable driver for PCI systems From: Niklas Schnelle Date: Mon, 14 Feb 2022 10:53:13 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit To: "Maciej W. Rozycki" Cc: Geert Uytterhoeven , Sudip Mukherjee , Catalin Marinas , Will Deacon , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Alexander Gordeev , Sven Schnelle , Jeff Dike , Richard Weinberger , Anton Ivanov , Chris Zankel , Max Filippov , linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, linux-kernel@vger.kernel.org List-ID: On Mon, 2022-02-14 at 09:21 +0000, Maciej W. Rozycki wrote: > On Mon, 14 Feb 2022, Niklas Schnelle wrote: > > > > > --- linux-macro.orig/drivers/parport/Kconfig > > > > +++ linux-macro/drivers/parport/Kconfig > > > > @@ -42,7 +42,7 @@ if PARPORT > > > > > > > > config PARPORT_PC > > > > tristate "PC-style hardware" > > > > - depends on ARCH_MIGHT_HAVE_PC_PARPORT > > > > + depends on ARCH_MIGHT_HAVE_PC_PARPORT || PCI > > > > This would allow selecting PARPORT_PC on s390 e.g. for allyesconfig and > > randconfig and like POWER9 we definitely do not support I/O port > > access. > > I guess we'll have to stop it with !S390 then short-term. I don't think > an issue with s390 should be blocking all the other platforms that can use > these drivers just fine. I'll post v2 with that installed if you agree. > > Maciej Though a bit ugly that sounds fine by me. Thanks.