From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8DF4-004Lc5-6W for linux-um@lists.infradead.org; Mon, 04 Jul 2022 03:59:23 +0000 Received: by mail-pg1-f199.google.com with SMTP id 189-20020a6309c6000000b0041249d53b04so371241pgj.22 for ; Sun, 03 Jul 2022 20:59:18 -0700 (PDT) Message-ID: <6daca7fd-ae2a-cd0c-2030-3c6e503a3200@redhat.com> Date: Mon, 4 Jul 2022 11:59:03 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v11 08/40] virtio_ring: split: extract the logic of alloc queue References: <20220629065656.54420-1-xuanzhuo@linux.alibaba.com> <20220629065656.54420-9-xuanzhuo@linux.alibaba.com> <3e36e44f-1f37-ad02-eb89-833a0856ec4e@redhat.com> <1656665158.0036178-3-xuanzhuo@linux.alibaba.com> From: Jason Wang In-Reply-To: <1656665158.0036178-3-xuanzhuo@linux.alibaba.com> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Xuan Zhuo Cc: Richard Weinberger , Anton Ivanov , Johannes Berg , "Michael S. Tsirkin" , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Hans de Goede , Mark Gross , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Eric Farman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Vincent Whitchurch , linux-um@lists.infradead.org, netdev@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, bpf@vger.kernel.org, kangjie.xu@linux.alibaba.com, virtualization@lists.linux-foundation.org CuWcqCAyMDIyLzcvMSAxNjo0NSwgWHVhbiBaaHVvIOWGmemBkzoKPiBPbiBGcmksIDEgSnVsIDIw MjIgMTY6MjY6MjUgKzA4MDAsIEphc29uIFdhbmcgPGphc293YW5nQHJlZGhhdC5jb20+IHdyb3Rl Ogo+PiDlnKggMjAyMi82LzI5IDE0OjU2LCBYdWFuIFpodW8g5YaZ6YGTOgo+Pj4gU2VwYXJhdGUg dGhlIGxvZ2ljIG9mIHNwbGl0IHRvIGNyZWF0ZSB2cmluZyBxdWV1ZS4KPj4+Cj4+PiBUaGlzIGZl YXR1cmUgaXMgcmVxdWlyZWQgZm9yIHN1YnNlcXVlbnQgdmlydHVxdWV1ZSByZXNldCB2cmluZy4K Pj4+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBYdWFuIFpodW8gPHh1YW56aHVvQGxpbnV4LmFsaWJhYmEu Y29tPgo+Pj4gLS0tCj4+PiAgICBkcml2ZXJzL3ZpcnRpby92aXJ0aW9fcmluZy5jIHwgNjggKysr KysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tCj4+PiAgICAxIGZpbGUgY2hhbmdlZCwg NDIgaW5zZXJ0aW9ucygrKSwgMjYgZGVsZXRpb25zKC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvdmlydGlvL3ZpcnRpb19yaW5nLmMgYi9kcml2ZXJzL3ZpcnRpby92aXJ0aW9fcmluZy5j Cj4+PiBpbmRleCA0OWQ2MWU0MTJkYzYuLmE5Y2ViOWMxNmM1NCAxMDA2NDQKPj4+IC0tLSBhL2Ry aXZlcnMvdmlydGlvL3ZpcnRpb19yaW5nLmMKPj4+ICsrKyBiL2RyaXZlcnMvdmlydGlvL3ZpcnRp b19yaW5nLmMKPj4+IEBAIC05NDksMjggKzk0OSwxOSBAQCBzdGF0aWMgdm9pZCB2cmluZ19mcmVl X3NwbGl0KHN0cnVjdCB2cmluZ192aXJ0cXVldWVfc3BsaXQgKnZyaW5nLAo+Pj4gICAgCWtmcmVl KHZyaW5nLT5kZXNjX2V4dHJhKTsKPj4+ICAgIH0KPj4+Cj4+PiAtc3RhdGljIHN0cnVjdCB2aXJ0 cXVldWUgKnZyaW5nX2NyZWF0ZV92aXJ0cXVldWVfc3BsaXQoCj4+PiAtCXVuc2lnbmVkIGludCBp bmRleCwKPj4+IC0JdW5zaWduZWQgaW50IG51bSwKPj4+IC0JdW5zaWduZWQgaW50IHZyaW5nX2Fs aWduLAo+Pj4gLQlzdHJ1Y3QgdmlydGlvX2RldmljZSAqdmRldiwKPj4+IC0JYm9vbCB3ZWFrX2Jh cnJpZXJzLAo+Pj4gLQlib29sIG1heV9yZWR1Y2VfbnVtLAo+Pj4gLQlib29sIGNvbnRleHQsCj4+ PiAtCWJvb2wgKCpub3RpZnkpKHN0cnVjdCB2aXJ0cXVldWUgKiksCj4+PiAtCXZvaWQgKCpjYWxs YmFjaykoc3RydWN0IHZpcnRxdWV1ZSAqKSwKPj4+IC0JY29uc3QgY2hhciAqbmFtZSkKPj4+ICtz dGF0aWMgaW50IHZyaW5nX2FsbG9jX3F1ZXVlX3NwbGl0KHN0cnVjdCB2cmluZ192aXJ0cXVldWVf c3BsaXQgKnZyaW5nLAo+Pj4gKwkJCQkgICBzdHJ1Y3QgdmlydGlvX2RldmljZSAqdmRldiwKPj4+ ICsJCQkJICAgdTMyIG51bSwKPj4+ICsJCQkJICAgdW5zaWduZWQgaW50IHZyaW5nX2FsaWduLAo+ Pj4gKwkJCQkgICBib29sIG1heV9yZWR1Y2VfbnVtKQo+Pj4gICAgewo+Pj4gLQlzdHJ1Y3Qgdmly dHF1ZXVlICp2cTsKPj4+ICAgIAl2b2lkICpxdWV1ZSA9IE5VTEw7Cj4+PiAgICAJZG1hX2FkZHJf dCBkbWFfYWRkcjsKPj4+IC0Jc2l6ZV90IHF1ZXVlX3NpemVfaW5fYnl0ZXM7Cj4+PiAtCXN0cnVj dCB2cmluZyB2cmluZzsKPj4+Cj4+PiAgICAJLyogV2UgYXNzdW1lIG51bSBpcyBhIHBvd2VyIG9m IDIuICovCj4+PiAgICAJaWYgKG51bSAmIChudW0gLSAxKSkgewo+Pj4gICAgCQlkZXZfd2Fybigm dmRldi0+ZGV2LCAiQmFkIHZpcnRxdWV1ZSBsZW5ndGggJXVcbiIsIG51bSk7Cj4+PiAtCQlyZXR1 cm4gTlVMTDsKPj4+ICsJCXJldHVybiAtRUlOVkFMOwo+Pj4gICAgCX0KPj4+Cj4+PiAgICAJLyog VE9ETzogYWxsb2NhdGUgZWFjaCBxdWV1ZSBjaHVuayBpbmRpdmlkdWFsbHkgKi8KPj4+IEBAIC05 ODEsMTEgKzk3MiwxMSBAQCBzdGF0aWMgc3RydWN0IHZpcnRxdWV1ZSAqdnJpbmdfY3JlYXRlX3Zp cnRxdWV1ZV9zcGxpdCgKPj4+ICAgIAkJaWYgKHF1ZXVlKQo+Pj4gICAgCQkJYnJlYWs7Cj4+PiAg ICAJCWlmICghbWF5X3JlZHVjZV9udW0pCj4+PiAtCQkJcmV0dXJuIE5VTEw7Cj4+PiArCQkJcmV0 dXJuIC1FTk9NRU07Cj4+PiAgICAJfQo+Pj4KPj4+ICAgIAlpZiAoIW51bSkKPj4+IC0JCXJldHVy biBOVUxMOwo+Pj4gKwkJcmV0dXJuIC1FTk9NRU07Cj4+Pgo+Pj4gICAgCWlmICghcXVldWUpIHsK Pj4+ICAgIAkJLyogVHJ5IHRvIGdldCBhIHNpbmdsZSBwYWdlLiBZb3UgYXJlIG15IG9ubHkgaG9w ZSEgKi8KPj4+IEBAIC05OTMsMjEgKzk4NCw0NiBAQCBzdGF0aWMgc3RydWN0IHZpcnRxdWV1ZSAq dnJpbmdfY3JlYXRlX3ZpcnRxdWV1ZV9zcGxpdCgKPj4+ICAgIAkJCQkJICAmZG1hX2FkZHIsIEdG UF9LRVJORUx8X19HRlBfWkVSTyk7Cj4+PiAgICAJfQo+Pj4gICAgCWlmICghcXVldWUpCj4+PiAt CQlyZXR1cm4gTlVMTDsKPj4+ICsJCXJldHVybiAtRU5PTUVNOwo+Pj4gKwo+Pj4gKwl2cmluZ19p bml0KCZ2cmluZy0+dnJpbmcsIG51bSwgcXVldWUsIHZyaW5nX2FsaWduKTsKPj4+Cj4+PiAtCXF1 ZXVlX3NpemVfaW5fYnl0ZXMgPSB2cmluZ19zaXplKG51bSwgdnJpbmdfYWxpZ24pOwo+Pj4gLQl2 cmluZ19pbml0KCZ2cmluZywgbnVtLCBxdWV1ZSwgdnJpbmdfYWxpZ24pOwo+Pj4gKwl2cmluZy0+ cXVldWVfZG1hX2FkZHIgPSBkbWFfYWRkcjsKPj4+ICsJdnJpbmctPnF1ZXVlX3NpemVfaW5fYnl0 ZXMgPSB2cmluZ19zaXplKG51bSwgdnJpbmdfYWxpZ24pOwo+Pj4gKwo+Pj4gKwlyZXR1cm4gMDsK Pj4+ICt9Cj4+PiArCj4+PiArc3RhdGljIHN0cnVjdCB2aXJ0cXVldWUgKnZyaW5nX2NyZWF0ZV92 aXJ0cXVldWVfc3BsaXQoCj4+PiArCXVuc2lnbmVkIGludCBpbmRleCwKPj4+ICsJdW5zaWduZWQg aW50IG51bSwKPj4+ICsJdW5zaWduZWQgaW50IHZyaW5nX2FsaWduLAo+Pj4gKwlzdHJ1Y3Qgdmly dGlvX2RldmljZSAqdmRldiwKPj4+ICsJYm9vbCB3ZWFrX2JhcnJpZXJzLAo+Pj4gKwlib29sIG1h eV9yZWR1Y2VfbnVtLAo+Pj4gKwlib29sIGNvbnRleHQsCj4+PiArCWJvb2wgKCpub3RpZnkpKHN0 cnVjdCB2aXJ0cXVldWUgKiksCj4+PiArCXZvaWQgKCpjYWxsYmFjaykoc3RydWN0IHZpcnRxdWV1 ZSAqKSwKPj4+ICsJY29uc3QgY2hhciAqbmFtZSkKPj4+ICt7Cj4+PiArCXN0cnVjdCB2cmluZ192 aXJ0cXVldWVfc3BsaXQgdnJpbmcgPSB7fTsKPj4+ICsJc3RydWN0IHZpcnRxdWV1ZSAqdnE7Cj4+ PiArCWludCBlcnI7Cj4+PiArCj4+PiArCWVyciA9IHZyaW5nX2FsbG9jX3F1ZXVlX3NwbGl0KCZ2 cmluZywgdmRldiwgbnVtLCB2cmluZ19hbGlnbiwKPj4+ICsJCQkJICAgICAgbWF5X3JlZHVjZV9u dW0pOwo+Pj4gKwlpZiAoZXJyKQo+Pj4gKwkJcmV0dXJuIE5VTEw7Cj4+Pgo+Pj4gLQl2cSA9IF9f dnJpbmdfbmV3X3ZpcnRxdWV1ZShpbmRleCwgdnJpbmcsIHZkZXYsIHdlYWtfYmFycmllcnMsIGNv bnRleHQsCj4+PiAtCQkJCSAgIG5vdGlmeSwgY2FsbGJhY2ssIG5hbWUpOwo+Pj4gKwl2cSA9IF9f dnJpbmdfbmV3X3ZpcnRxdWV1ZShpbmRleCwgdnJpbmcudnJpbmcsIHZkZXYsIHdlYWtfYmFycmll cnMsCj4+PiArCQkJCSAgIGNvbnRleHQsIG5vdGlmeSwgY2FsbGJhY2ssIG5hbWUpOwo+Pj4gICAg CWlmICghdnEpIHsKPj4+IC0JCXZyaW5nX2ZyZWVfcXVldWUodmRldiwgcXVldWVfc2l6ZV9pbl9i eXRlcywgcXVldWUsCj4+PiAtCQkJCSBkbWFfYWRkcik7Cj4+PiArCQl2cmluZ19mcmVlX3NwbGl0 KCZ2cmluZywgdmRldik7Cj4+PiAgICAJCXJldHVybiBOVUxMOwo+Pj4gICAgCX0KPj4+Cj4+PiAt CXRvX3Z2cSh2cSktPnNwbGl0LnF1ZXVlX2RtYV9hZGRyID0gZG1hX2FkZHI7Cj4+PiAtCXRvX3Z2 cSh2cSktPnNwbGl0LnF1ZXVlX3NpemVfaW5fYnl0ZXMgPSBxdWV1ZV9zaXplX2luX2J5dGVzOwo+ Pj4gKwl0b192dnEodnEpLT5zcGxpdC5xdWV1ZV9kbWFfYWRkciA9IHZyaW5nLnF1ZXVlX2RtYV9h ZGRyOwo+Pgo+PiBOaXQ6IGhhdmluZyB0d28gcXVldWVfZG1hX2FkZHIgc2VlbXMgcmVkdW5kYW50 IChzbyBkaWQgcXVldWVfc2l6ZV9pbl9ieXRlcykuCj4gdHdvPwo+Cj4gV2hlcmUgaXMgdGhlIHBy b2JsZW0gSSBkb24ndCB1bmRlcnN0YW5kPwo+Cj4gVGhhbmtzLgoKCkkgbWVhbnQgd2UgaGFkOgoK IMKgwqDCoMKgwqDCoMKgIHZyaW5nLnZyaW5nID0gX3ZyaW5nOwoKaW4gX192cmluZ19uZXdfdmly dHF1ZXVlKCkuCgpUaGlzIG1lYW5zIHdlJ2QgYmV0dGVyIGluaXRpYWxpemUgdnJpbmcgZnVsbHkg YmVmb3JlIHRoYXQ/CgpFLmcKCnZyaW5nLnF1ZXVlX2RtYV9hZGRyID0gZG1hX2FkZHI7CgouLi4K Cl9fdnJpbmdfbmV3X3ZpcnRxdWV1ZSgpCgpUaGFua3MKCgo+Cj4+IFRoYW5rcwo+Pgo+Pgo+Pj4g Kwl0b192dnEodnEpLT5zcGxpdC5xdWV1ZV9zaXplX2luX2J5dGVzID0gdnJpbmcucXVldWVfc2l6 ZV9pbl9ieXRlczsKPj4+ICAgIAl0b192dnEodnEpLT53ZV9vd25fcmluZyA9IHRydWU7Cj4+Pgo+ Pj4gICAgCXJldHVybiB2cTsKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC11bSBtYWlsaW5nIGxpc3QKbGludXgtdW1AbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXVt Cg==