From: Johannes Berg <johannes@sipsolutions.net>
To: linux-um@lists.infradead.org
Cc: "Mickaël Salaün" <mic@digikod.net>, "Arnd Bergmann" <arnd@arndb.de>
Subject: Re: [PATCH v2] hostfs: fix dev_t handling
Date: Tue, 02 Jul 2024 09:57:14 +0200 [thread overview]
Message-ID: <6e01a4c7ebf568f17f92e75621cb8dfe357fa651.camel@sipsolutions.net> (raw)
In-Reply-To: <20240702092440.acc960585dd5.Id0767e12f562a69c6cd3c3262dc3d765db350cf6@changeid>
On Tue, 2024-07-02 at 09:24 +0200, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> dev_t is a kernel type and may have different definitions
> in kernel and userspace. On 32-bit x86 this currently makes
> the stat structure being 4 bytes longer in the user code,
> causing stack corruption.
>
> However, this is (potentially) not the only problem, since
> dev_t is a different type on user/kernel side, so we don't
> know that the major/minor encoding isn't also different.
> Decode/encode it instead to address both problems.
>
> Fixes: 74ce793bcbde ("hostfs: Fix ephemeral inodes")
Probably should be Cc: stable too
johannes
prev parent reply other threads:[~2024-07-02 7:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 7:24 [PATCH v2] hostfs: fix dev_t handling Johannes Berg
2024-07-02 7:57 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e01a4c7ebf568f17f92e75621cb8dfe357fa651.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arnd@arndb.de \
--cc=linux-um@lists.infradead.org \
--cc=mic@digikod.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox