linux-um archives
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Karel Zak <kzak@redhat.com>, Hongbo Li <lihongbo22@huawei.com>
Cc: linux-um@lists.infradead.org, linux-fsdevel@vger.kernel.org,
	Christian Brauner <brauner@kernel.org>,
	Benjamin Berg <benjamin@sipsolutions.net>,
	rrs@debian.org
Subject: Re: UML mount failure with Linux 6.11
Date: Tue, 26 Nov 2024 14:50:38 +0100	[thread overview]
Message-ID: <6e6ccc76005d8c53370d8bdcb0e520e10b2b7193.camel@sipsolutions.net> (raw)
In-Reply-To: <ykwlncqgbsv7xilipxjs2xoxjpkdhss4gb5tssah7pjd76iqxf@o2vkkrjh2mgd>

On Mon, 2024-11-25 at 18:43 +0100, Karel Zak wrote:
> 
> The long-term solution would be to clean up hostfs and use named
> variables, such as "mount -t hostfs none -o 'path="/home/hostfs"'.

That's what Hongbo's commit *did*, afaict, but it is a regression.

Now most of the regression is that with fsconfig() call it was no longer
possible to specify a bare folder, and then we got discussing what
happens if the folder name actually contains a comma...

But this is still a regression, so we need to figure out what to do
short term?

Ignoring the "path with comma" issue, because we can't even fix that in
the kernel given what you describe changed in userspace, we can probably
only

 1) revert the hostfs conversion to the new API, or
 2) somehow not require the hostfs= key?

I don't know if either of those are even possible


Fixing the regression fully (including for paths containing commas)
probably also requires userspace changes. If you don't want to make
those we can only point to your workarounds instead, since we can't do
anything on the kernel side.

I don't know the fsconfig() API, is it possible to have key-less or
value-less calls? What does happen 

johannes


  reply	other threads:[~2024-11-26 13:50 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30  8:13 UML mount failure with Linux 6.11 Ritesh Raj Sarraf
2024-10-31 10:07 ` Benjamin Berg
2024-11-06 11:52   ` Ritesh Raj Sarraf
2024-11-06 19:25     ` Benjamin Berg
2024-11-07  6:22       ` Hongbo Li
2024-11-07 13:09         ` Johannes Berg
2024-11-07 14:17           ` Hongbo Li
2024-11-07 14:35             ` Johannes Berg
2024-11-11  1:16               ` Hongbo Li
2024-11-12 20:10                 ` Karel Zak
2024-11-13  1:23                   ` Hongbo Li
2024-11-21 13:53                     ` Hongbo Li
2024-11-25 17:43                       ` Karel Zak
2024-11-26 13:50                         ` Johannes Berg [this message]
2024-11-27  1:26                           ` Hongbo Li
2024-11-27 12:02                             ` Karel Zak
2024-11-27 13:15                               ` Johannes Berg
2024-11-28 10:58                                 ` Karel Zak
2024-11-28 12:55                                   ` Johannes Berg
2024-11-27 13:55                               ` Hongbo Li
2024-11-27 11:55                           ` Karel Zak
2024-11-27 12:16                             ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e6ccc76005d8c53370d8bdcb0e520e10b2b7193.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=benjamin@sipsolutions.net \
    --cc=brauner@kernel.org \
    --cc=kzak@redhat.com \
    --cc=lihongbo22@huawei.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=rrs@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox