From: Richard Weinberger <richard@nod.at>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Peter Hüwe" <PeterHuewe@gmx.de>,
"Jean Delvare" <khali@linux-fr.org>,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] Emulate I2C subsystem/slaves
Date: Sun, 09 Sep 2012 17:00:54 +0200 [thread overview]
Message-ID: <709c5ec5-fff8-46af-bd7e-31e1f660285b@email.android.com> (raw)
In-Reply-To: <CAMuHMdVBEYk0wvG+Xd-pk3DUj852ab1CFwSjg_os3MJpRXcBpA@mail.gmail.com>
Geert Uytterhoeven <geert@linux-m68k.org> schrieb:
>On Sun, Sep 9, 2012 at 3:27 PM, Richard Weinberger <richard@nod.at>
>wrote:
>>> For my stub driver I don't need any of that, I'd be fine with the
>move of
>>> HAS_IOMEM as proposed by Jean.
>>
>> IMHO you should replace the HAS_IOMEM with GENERIC_IO.
>> Otherwise you may break the build on s390.
>
>s390 has neither of HAS_IOMEM and GENERIC_IO, so it won't break their
>build.
>
>Gr{oetje,eeting}s,
>
> Geert
>
>--
>Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
>geert@linux-m68k.org
>
>In personal conversations with technical people, I call myself a
>hacker. But
>when I'm talking to journalists I just say "programmer" or something
>like that.
> -- Linus Torvalds
That's why it may break. If you remove the depends on HAS_IOMEM, it will be built on s390 and fail if that codes uses io memory functions. Depending on GENERIC_IO fixes that.
next prev parent reply other threads:[~2012-09-09 15:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-02 20:45 [uml-devel] Emulate I2C subsystem/slaves Peter Hüwe
2012-09-03 12:52 ` Richard Weinberger
2012-09-09 1:08 ` Peter Hüwe
2012-09-09 8:13 ` Geert Uytterhoeven
2012-09-09 10:49 ` Peter Hüwe
2012-09-09 11:28 ` Jean Delvare
2012-09-09 12:15 ` Peter Hüwe
2012-09-09 12:21 ` Geert Uytterhoeven
2012-09-09 12:23 ` Richard Weinberger
2012-09-09 12:52 ` Peter Hüwe
2012-09-09 12:57 ` Richard Weinberger
2012-09-09 13:11 ` Peter Hüwe
2012-09-09 13:27 ` Richard Weinberger
2012-09-09 14:52 ` Geert Uytterhoeven
2012-09-09 15:00 ` Richard Weinberger [this message]
2012-09-09 15:48 ` Jean Delvare
2012-09-09 19:12 ` Peter Hüwe
2012-09-09 20:08 ` Richard Weinberger
2012-09-09 13:04 ` Richard Weinberger
2012-09-09 18:40 ` Jean Delvare
2012-09-09 19:17 ` Peter Hüwe
2012-09-10 7:29 ` Jean Delvare
2012-09-10 19:21 ` Peter Hüwe
2012-09-11 15:03 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=709c5ec5-fff8-46af-bd7e-31e1f660285b@email.android.com \
--to=richard@nod.at \
--cc=PeterHuewe@gmx.de \
--cc=geert@linux-m68k.org \
--cc=khali@linux-fr.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox