From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [RFC PATCH v2 1/3] mm/gup: fix gup_fast with dynamic page table folding References: <20200907180058.64880-1-gerald.schaefer@linux.ibm.com> <20200907180058.64880-2-gerald.schaefer@linux.ibm.com> <82fbe8f9-f199-5fc2-4168-eb43ad0b0346@csgroup.eu> From: Christian Borntraeger Message-ID: <70a3dcb5-5ed1-6efa-6158-d0573d6927da@de.ibm.com> Date: Tue, 8 Sep 2020 14:09:01 +0200 In-Reply-To: <82fbe8f9-f199-5fc2-4168-eb43ad0b0346@csgroup.eu> Content-Language: en-US MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Christophe Leroy , Gerald Schaefer , Jason Gunthorpe , John Hubbard Cc: Peter Zijlstra , Catalin Marinas , Dave Hansen , linux-mm , Paul Mackerras , linux-sparc , Alexander Gordeev , Claudio Imbrenda , Will Deacon , linux-arch , linux-s390 , Vasily Gorbik , Richard Weinberger , linux-x86 , Russell King , Ingo Molnar , Andrey Ryabinin , Jeff Dike , Arnd Bergmann , Heiko Carstens , linux-um , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , linux-arm , Linus Torvalds , LKML , Andrew Morton , linux-power , Mike Rapoport CgpPbiAwOC4wOS4yMCAwNzowNiwgQ2hyaXN0b3BoZSBMZXJveSB3cm90ZToKPiAKPiAKPiBMZSAw Ny8wOS8yMDIwIMOgIDIwOjAwLCBHZXJhbGQgU2NoYWVmZXIgYSDDqWNyaXTCoDoKPj4gRnJvbTog QWxleGFuZGVyIEdvcmRlZXYgPGFnb3JkZWV2QGxpbnV4LmlibS5jb20+Cj4+Cj4+IENvbW1pdCAx YTQyMDEwY2RjMjYgKCJzMzkwL21tOiBjb252ZXJ0IHRvIHRoZSBnZW5lcmljIGdldF91c2VyX3Bh Z2VzX2Zhc3QKPj4gY29kZSIpIGludHJvZHVjZWQgYSBzdWJ0bGUgYnV0IHNldmVyZSBidWcgb24g czM5MCB3aXRoIGd1cF9mYXN0LCBkdWUgdG8KPj4gZHluYW1pYyBwYWdlIHRhYmxlIGZvbGRpbmcu Cj4+Cj4+IFRoZSBxdWVzdGlvbiAiV2hhdCB3b3VsZCBpdCByZXF1aXJlIGZvciB0aGUgZ2VuZXJp YyBjb2RlIHRvIHdvcmsgZm9yIHMzOTAiCj4+IGhhcyBhbHJlYWR5IGJlZW4gZGlzY3Vzc2VkIGhl cmUKPj4gaHR0cHM6Ly9sa21sLmtlcm5lbC5vcmcvci8yMDE5MDQxODEwMDIxOC4wYTRhZmQ1MUBt c2Nod2lkZVgxCj4+IGFuZCBlbmRlZCB3aXRoIGEgcHJvbWlzaW5nIGFwcHJvYWNoIGhlcmUKPj4g aHR0cHM6Ly9sa21sLmtlcm5lbC5vcmcvci8yMDE5MDQxOTE1MzMwNy40ZjI5MTFiNUBtc2Nod2lk ZVgxCj4+IHdoaWNoIGluIHRoZSBlbmQgdW5mb3J0dW5hdGVseSBkaWRuJ3QgcXVpdGUgd29yayBj b21wbGV0ZWx5Lgo+Pgo+PiBXZSB0cmllZCB0byBtaW1pYyBzdGF0aWMgbGV2ZWwgZm9sZGluZyBi eSBjaGFuZ2luZyBwZ2Rfb2Zmc2V0IHRvIGFsd2F5cwo+PiBjYWxjdWxhdGUgdG9wIGxldmVsIHBh Z2UgdGFibGUgb2Zmc2V0LCBhbmQgZG8gbm90aGluZyBpbiBmb2xkZWQgcFhkX29mZnNldC4KPj4g V2hhdCBoYXMgYmVlbiBvdmVybG9va2VkIGlzIHRoYXQgUHhEX1NJWkUvTUFTSyBhbmQgdGh1cyBw WGRfYWRkcl9lbmQgZG8KPj4gbm90IHJlZmxlY3QgdGhpcyBkeW5hbWljIGJlaGF2aW91ciwgYW5k IHN0aWxsIGFjdCBsaWtlIHN0YXRpYyA1LWxldmVsCj4+IHBhZ2UgdGFibGVzLgo+Pgo+IAo+IFsu Li5dCj4gCj4+Cj4+IEZpeCB0aGlzIGJ5IGludHJvZHVjaW5nIG5ldyBwWGRfYWRkcl9lbmRfZm9s ZGVkIGhlbHBlcnMsIHdoaWNoIHRha2UgYW4KPj4gYWRkaXRpb25hbCBwWGQgZW50cnkgdmFsdWUg cGFyYW1ldGVyLCB0aGF0IGNhbiBiZSB1c2VkIG9uIHMzOTAKPj4gdG8gZGV0ZXJtaW5lIHRoZSBj b3JyZWN0IHBhZ2UgdGFibGUgbGV2ZWwgYW5kIHJldHVybiBjb3JyZXNwb25kaW5nCj4+IGVuZCAv IGJvdW5kYXJ5LiBXaXRoIHRoYXQsIHRoZSBwb2ludGVyIGl0ZXJhdGlvbiB3aWxsIGFsd2F5cwo+ PiBoYXBwZW4gaW4gZ3VwX3BnZF9yYW5nZSBmb3IgczM5MC4gTm8gY2hhbmdlIGZvciBvdGhlciBh cmNoaXRlY3R1cmVzCj4+IGludHJvZHVjZWQuCj4gCj4gTm90IHN1cmUgcFhkX2FkZHJfZW5kX2Zv bGRlZCgpIGlzIHRoZSBiZXN0IHVuZGVyc3RhbmRhYmxlIG5hbWUsIGFsbHRob3VnaCBJIGRvbid0 IGhhdmUgYW55IGFsdGVybmF0aXZlIHN1Z2dlc3Rpb24gYXQgdGhlIG1vbWVudC4KPiBNYXliZSBj b3VsZCBiZSBzb21ldGhpbmcgbGlrZSBwWGRfYWRkcl9lbmRfZml4dXAoKSBhcyBpdCB3aWxsIGRp c2FwcGVhciBpbiB0aGUgbmV4dCBwYXRjaCwgb3IgcFhkX2FkZHJfZW5kX2d1cCgpID8KPiAKPiBB bHNvLCBpZiBpdCBoYXBwZW5zIHRvIGJlIGFjY2VwdGFibGUgdG8gZ2V0IHBhdGNoIDIgaW4gc3Rh YmxlLCBJIHRoaW5rIHlvdSBzaG91bGQgc3dpdGNoIHBhdGNoIDEgYW5kIHBhdGNoIDIgdG8gYXZv aWQgdGhlIHN0ZXAgdGhyb3VnaCBwWGRfYWRkcl9lbmRfZm9sZGVkKCkKCmdpdmVuIHRoYXQgdGhp cyBmaXhlcyBhIGRhdGEgY29ycnVwdGlvbiBpc3N1ZSwgd291bGRudCBpdCBiZSB0aGUgYmVzdCB0 byBnbyBmb3J3YXJkCndpdGggdGhpcyBwYXRjaCBBU0FQIGFuZCB0aGVuIGhhbmRsZSB0aGUgb3Ro ZXIgcGF0Y2hlcyBvbiB0b3Agd2l0aCBhbGwgdGhlIHRpbWUgdGhhdAp3ZSBuZWVkPwo+IAo+IAo+ Pgo+PiBGaXhlczogMWE0MjAxMGNkYzI2ICgiczM5MC9tbTogY29udmVydCB0byB0aGUgZ2VuZXJp YyBnZXRfdXNlcl9wYWdlc19mYXN0IGNvZGUiKQo+PiBDYzogPHN0YWJsZUB2Z2VyLmtlcm5lbC5v cmc+ICMgNS4yKwo+PiBSZXZpZXdlZC1ieTogR2VyYWxkIFNjaGFlZmVyIDxnZXJhbGQuc2NoYWVm ZXJAbGludXguaWJtLmNvbT4KPj4gU2lnbmVkLW9mZi1ieTogQWxleGFuZGVyIEdvcmRlZXYgPGFn b3JkZWV2QGxpbnV4LmlibS5jb20+Cj4+IFNpZ25lZC1vZmYtYnk6IEdlcmFsZCBTY2hhZWZlciA8 Z2VyYWxkLnNjaGFlZmVyQGxpbnV4LmlibS5jb20+Cj4+IC0tLQo+PiDCoCBhcmNoL3MzOTAvaW5j bHVkZS9hc20vcGd0YWJsZS5oIHwgNDIgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr Cj4+IMKgIGluY2x1ZGUvbGludXgvcGd0YWJsZS5owqDCoMKgwqDCoMKgwqDCoCB8IDE2ICsrKysr KysrKysrKysKPj4gwqAgbW0vZ3VwLmPCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIHzCoCA4ICsrKy0tLS0KPj4gwqAgMyBmaWxlcyBjaGFuZ2VkLCA2MiBpbnNl cnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvYXJjaC9zMzkwL2lu Y2x1ZGUvYXNtL3BndGFibGUuaCBiL2FyY2gvczM5MC9pbmNsdWRlL2FzbS9wZ3RhYmxlLmgKPj4g aW5kZXggN2ViMDFhNTQ1OWNkLi4wMjcyMDZlNDk1OWQgMTAwNjQ0Cj4+IC0tLSBhL2FyY2gvczM5 MC9pbmNsdWRlL2FzbS9wZ3RhYmxlLmgKPj4gKysrIGIvYXJjaC9zMzkwL2luY2x1ZGUvYXNtL3Bn dGFibGUuaAo+PiBAQCAtNTEyLDYgKzUxMiw0OCBAQCBzdGF0aWMgaW5saW5lIGJvb2wgbW1fcG1k X2ZvbGRlZChzdHJ1Y3QgbW1fc3RydWN0ICptbSkKPj4gwqAgfQo+PiDCoCAjZGVmaW5lIG1tX3Bt ZF9mb2xkZWQobW0pIG1tX3BtZF9mb2xkZWQobW0pCj4+IMKgICsvKgo+PiArICogV2l0aCBkeW5h bWljIHBhZ2UgdGFibGUgbGV2ZWxzIG9uIHMzOTAsIHRoZSBzdGF0aWMgcFhkX2FkZHJfZW5kKCkg ZnVuY3Rpb25zCj4+ICsgKiB3aWxsIG5vdCByZXR1cm4gY29ycmVzcG9uZGluZyBkeW5hbWljIGJv dW5kYXJpZXMuIFRoaXMgaXMgbm8gcHJvYmxlbSBhcyBsb25nCj4+ICsgKiBhcyBvbmx5IHBYZCBw b2ludGVycyBhcmUgcGFzc2VkIGRvd24gZHVyaW5nIHBhZ2UgdGFibGUgd2FsaywgYmVjYXVzZQo+ PiArICogcFhkX29mZnNldCgpIHdpbGwgc2ltcGx5IHJldHVybiB0aGUgZ2l2ZW4gcG9pbnRlciBm b3IgZm9sZGVkIGxldmVscywgYW5kIHRoZQo+PiArICogcG9pbnRlciBpdGVyYXRpb24gb3ZlciBh IHJhbmdlIHNpbXBseSBoYXBwZW5zIGF0IHRoZSBjb3JyZWN0IHBhZ2UgdGFibGUKPj4gKyAqIGxl dmVsLgo+PiArICogSXQgaXMgaG93ZXZlciBhIHByb2JsZW0gd2l0aCBndXBfZmFzdCwgb3Igb3Ro ZXIgcGxhY2VzIHdhbGtpbmcgdGhlIHBhZ2UKPj4gKyAqIHRhYmxlcyB3L28gbG9ja3MgdXNpbmcg UkVBRF9PTkNFKCksIGFuZCBwYXNzaW5nIGRvd24gdGhlIHBYZCB2YWx1ZXMgaW5zdGVhZAo+PiAr ICogb2YgcG9pbnRlcnMuIEluIHRoaXMgY2FzZSwgdGhlIHBvaW50ZXIgZ2l2ZW4gdG8gcFhkX29m ZnNldCgpIGlzIGEgcG9pbnRlciB0bwo+PiArICogYSBzdGFjayB2YXJpYWJsZSwgd2hpY2ggY2Fu bm90IGJlIHVzZWQgZm9yIHBvaW50ZXIgaXRlcmF0aW9uIGF0IHRoZSBjb3JyZWN0Cj4+ICsgKiBs ZXZlbC4gSW5zdGVhZCwgdGhlIGl0ZXJhdGlvbiB0aGVuIGhhcyB0byBoYXBwZW4gYnkgZ29pbmcg dXAgdG8gcGdkIGxldmVsCj4+ICsgKiBhZ2Fpbi4gVG8gYWxsb3cgdGhpcywgcHJvdmlkZSBwWGRf YWRkcl9lbmRfZm9sZGVkKCkgZnVuY3Rpb25zIHdpdGggYW4KPj4gKyAqIGFkZGl0aW9uYWwgcFhk IHZhbHVlIHBhcmFtZXRlciwgd2hpY2ggY2FuIGJlIHVzZWQgb24gczM5MCB0byBkZXRlcm1pbmUg dGhlCj4+ICsgKiBmb2xkaW5nIGxldmVsIGFuZCByZXR1cm4gdGhlIGNvcnJlc3BvbmRpbmcgYm91 bmRhcnkuCj4+ICsgKi8KPj4gK3N0YXRpYyBpbmxpbmUgdW5zaWduZWQgbG9uZyByc3RlX2FkZHJf ZW5kX2ZvbGRlZCh1bnNpZ25lZCBsb25nIHJzdGUsIHVuc2lnbmVkIGxvbmcgYWRkciwgdW5zaWdu ZWQgbG9uZyBlbmQpCj4gCj4gV2hhdCBkb2VzICdyc3RlJyBzdGFuZHMgZm9yID8KPiAKPiBJc24n dCB0aGlzIGxpbmUgYSBiaXQgbG9uZyA/Cgp0aGlzIGlzIHJlZ2lvbi9zZWdtZW50IHRhYmxlIGVu dHJ5IGFjY29yZGluZyB0byB0aGUgYXJjaGl0ZWN0dXJlLiAKT24gb3VyIHBsYXRmb3JtIHdlIGRv IGhhdmUgdGhlIHBhZ2V0YWJsZXMgd2l0aCBhIGRpZmZlcmVudCBmb3JtYXQgdGhhdApuZXh0IGxl dmVscyAoc2VnbWVudCB0YWJsZSAtPiAxTUIgZ3JhbnVsYXJpdHksIHJlZ2lvbiAzcmQgdGFibGUg LT4gMiBHQgpncmFudWxhcml0eSwgcmVnaW9uIDJuZCB0YWJsZSAtPiA0VEIgZ3JhbnVsYXJpdHks IHJlZ2lvbiAxc3QgdGFibGUgLT4gOCBQQgpncmFudWxhcml0eS4gU1QsUjMsUjIsUjEgaGF2ZSB0 aGUgc2FtZSBmb3JtYXQgYW5kIGFyZSB0aHVzIG9mdGVuIGNhbGxlZApjcnN0ZSAoY29tYmluZWQg cmVnaW9uIGFuZCBzZWdtZW50IHRhYmxlIGVudHJ5KS4KCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXVtIG1haWxpbmcgbGlzdApsaW51eC11bUBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtdW0K