From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4EBCFC04FFE for ; Fri, 17 May 2024 11:21:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=E7wAkrAeaykYEQH/zXooNlUA5a9fuCn+Qu8bdbWdq0k=; b=kLtt/OiDzLBvOsT5JNOxT3CXEo R9Nf04c/AHAE57peeH5HpEeV38igHMGf9gzsi59nnixE8Ih7nj+c9v6ELtQL0mEu2zYT4Zez9howH UNXIhNvzANrKzP/y5EG82zN6RFhNxnDLLuXcdIrFsG9Y5im8VH14UW8+mRC0/pp4O8kGJ3Nt09RX3 VSiTEcsrwIe7apjEHBvxmICU6Mf+CHBszf739bRB68wEfAR0FjyILEuP6/u20t94kctfi0S1lPOI/ XgJ7WEkUNkJK5mkIA9PzERrsdgDEj8VY0meqBDaFO6ntN/A13IbW56abgGLRTofYVbxf6f+VAfYBS kD8BbhzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7veP-00000007dII-2EWE; Fri, 17 May 2024 11:21:25 +0000 Received: from szxga02-in.huawei.com ([45.249.212.188]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7veL-00000007dHP-1dr9 for linux-um@lists.infradead.org; Fri, 17 May 2024 11:21:23 +0000 Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4VgkyM3ZQKzcf8s; Fri, 17 May 2024 19:19:55 +0800 (CST) Received: from dggpeml500022.china.huawei.com (unknown [7.185.36.66]) by mail.maildlp.com (Postfix) with ESMTPS id C03391402CA; Fri, 17 May 2024 19:21:10 +0800 (CST) Received: from [10.67.111.104] (10.67.111.104) by dggpeml500022.china.huawei.com (7.185.36.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 17 May 2024 19:21:10 +0800 Message-ID: <74576c52-5eca-4961-ada4-a9ec99fb16cf@huawei.com> Date: Fri, 17 May 2024 19:21:09 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] hostfs: convert hostfs to use the new mount api To: Dan Carpenter , , , , CC: , , , References: Content-Language: en-US From: Hongbo Li In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.111.104] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500022.china.huawei.com (7.185.36.66) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240517_042121_927245_BBE91A71 X-CRM114-Status: UNSURE ( 9.43 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org Thanks for your attention, I have solved the warnings in the following patch (the similar title: hostfs: convert hostfs to use the new mount API): https://lore.kernel.org/all/20240515025536.3667017-1-lihongbo22@huawei.com/ or https://patchwork.ozlabs.org/project/linux-um/patch/20240515025536.3667017-1-lihongbo22@huawei.com/ It was strange that the kernel test robot did not send the results on the new patch. Thanks, Hongbo On 2024/5/17 19:01, Dan Carpenter wrote: > Hi Hongbo, > > kernel test robot noticed the following build warnings: > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Hongbo-Li/hostfs-convert-hostfs-to-use-the-new-mount-api/20240513-204233 > base: git://git.kernel.org/pub/scm/linux/kernel/git/uml/linux next > patch link: https://lore.kernel.org/r/20240513124141.3788846-1-lihongbo22%40huawei.com > patch subject: [PATCH] hostfs: convert hostfs to use the new mount api > config: um-randconfig-r081-20240517 (https://download.01.org/0day-ci/archive/20240517/202405171154.21q42SWy-lkp@intel.com/config) > compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project d3455f4ddd16811401fa153298fadd2f59f6914e) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Reported-by: Dan Carpenter > | Closes: https://lore.kernel.org/r/202405171154.21q42SWy-lkp@intel.com/ > > smatch warnings: > fs/hostfs/hostfs_kern.c:960 hostfs_fill_super() error: uninitialized symbol 'host_root'. > > vim +/host_root +960 fs/hostfs/hostfs_kern.c > > 2c2593890079e8 Hongbo Li 2024-05-13 938 static int hostfs_fill_super(struct super_block *sb, struct fs_context *fc) > ^1da177e4c3f41 Linus Torvalds 2005-04-16 939 { > 2c2593890079e8 Hongbo Li 2024-05-13 940 struct hostfs_fs_info *fsi = sb->s_fs_info; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 941 struct inode *root_inode; > 2c2593890079e8 Hongbo Li 2024-05-13 942 char *host_root; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 943 int err; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 944 > ^1da177e4c3f41 Linus Torvalds 2005-04-16 945 sb->s_blocksize = 1024; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 946 sb->s_blocksize_bits = 10; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 947 sb->s_magic = HOSTFS_SUPER_MAGIC; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 948 sb->s_op = &hostfs_sbops; > b26d4cd385fc51 Al Viro 2013-10-25 949 sb->s_d_op = &simple_dentry_operations; > 752fa51e4c5182 Wolfgang Illmeyer 2009-06-30 950 sb->s_maxbytes = MAX_LFS_FILESIZE; > ce72750f04d68a Sjoerd Simons 2021-11-05 951 err = super_setup_bdi(sb); > ce72750f04d68a Sjoerd Simons 2021-11-05 952 if (err) > 74ce793bcbde5c Mickaël Salaün 2023-06-12 953 return err; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 954 > b58c4e96192ee7 Andy Shevchenko 2020-03-20 955 /* NULL is printed as '(null)' by printf(): avoid that. */ > 2c2593890079e8 Hongbo Li 2024-05-13 956 if (fc->source == NULL) > 2c2593890079e8 Hongbo Li 2024-05-13 957 host_root = ""; > > Uninitialized on else path > > ^1da177e4c3f41 Linus Torvalds 2005-04-16 958 > 2c2593890079e8 Hongbo Li 2024-05-13 959 fsi->host_root_path = > 2c2593890079e8 Hongbo Li 2024-05-13 @960 kasprintf(GFP_KERNEL, "%s/%s", root_ino, host_root); > ^^^^^^^^^ > > > 2c2593890079e8 Hongbo Li 2024-05-13 961 if (fsi->host_root_path == NULL) > 74ce793bcbde5c Mickaël Salaün 2023-06-12 962 return -ENOMEM; >