Re: [uml-devel] [PATCH] Fix for 2.6.26 ptrace crash

["Peter Teoh" <htmldeveloper@gmail.com>]

Thanks, the patch worked for me too.

As an aside, may be u would want to sync with mainline:

http://lkml.org/lkml/2007/5/3/460

which would solve the problem Boaz posed as well?

(the patch above seemed to indicate a problem of post-3.4 vs pre-3.4 GCC:

http://www.gnu.org/software/gcc/gcc-3.4/changes.html

but your patch indicated something to do with 4.x GCC vs pre-3.4 GCC?)

Sorry if I don't get it correctly :-).

On Mon, Jul 21, 2008 at 11:46 PM, Jeff Dike <jdike@addtoit.com> wrote:
> I believe I figured out the ptrace crash that showed up with 2.6.26,
> thanks to Toralf Förster.
>
> The patch is below.
>
> I have one confirmation that this fixes the problem - I'd like a few
> more just to be sure.
>
>                        Jeff
>
> --
> Work email - jdike at linux dot intel dot com
>
> Index: linux-2.6.22/arch/um/include/init.h
> ===================================================================
> --- linux-2.6.22.orig/arch/um/include/init.h    2008-02-18 11:53:50.000000000 -0500
> +++ linux-2.6.22/arch/um/include/init.h 2008-07-20 18:06:35.000000000 -0400
> @@ -45,6 +45,8 @@ typedef void (*exitcall_t)(void);
>  # define __section(S) __attribute__ ((__section__(#S)))
>  #endif
>
> +#if __GNUC__ == 3
> +
>  #if __GNUC_MINOR__ >= 3
>  # define __used                        __attribute__((__used__))
>  #else
> @@ -52,6 +54,12 @@ typedef void (*exitcall_t)(void);
>  #endif
>
>  #else
> +#if __GNUC__ == 4
> +# define __used                        __attribute__((__used__))
> +#endif
> +#endif
> +
> +#else
>  #include <linux/compiler.h>
>  #endif
>  /* These are for everybody (although not all archs will actually
>



-- 
Regards,
Peter Teoh

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel