linux-um.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: kbuild test robot <fengguang.wu@intel.com>,
	Paul Burton <paul.burton@imgtec.com>,
	Jeff Dike <jdike@addtoit.com>,
	Richard Weinberger <richard@nod.at>,
	user-mode-linux-devel@lists.sourceforge.net,
	Lee Jones <lee.jones@linaro.org>, Arnd Bergmann <arnd@arndb.de>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Ralf Baechle <ralf@linux-mips.org>
Subject: [PATCH] auxdisplay: img-ascii-lcd: don't build without HAS_IOMEM
Date: Sun, 1 Jan 2017 18:42:38 -0800	[thread overview]
Message-ID: <81455897-f6c1-79c1-7410-eff7656c1a0f@infradead.org> (raw)

From: Randy Dunlap <rdunlap@infradead.org>

Fix build error when the driver is built for arch/um, which does not
support HAS_IOMEM. Furthermore, the in-tree SYSCON drivers also require
HAS_IOMEM.

drivers/built-in.o: In function `img_ascii_lcd_probe':
drivers/auxdisplay/img-ascii-lcd.c:384: undefined reference to `devm_ioremap_resource'

Paul: there is no SYSCON kconfig symbol in the kernel tree. Should that
be MFD_SYSCON or GPIO_SYSCON?
Also, there is no MIPS_SEAD3 kconfig symbol either. Please fix that.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Cc:	Paul Burton <paul.burton@imgtec.com>
Cc:	Jeff Dike <jdike@addtoit.com>
Cc:	Richard Weinberger <richard@nod.at>
Cc:	user-mode-linux-devel@lists.sourceforge.net
Cc:	Lee Jones <lee.jones@linaro.org>
Cc:	Arnd Bergmann <arnd@arndb.de>
Cc:	Geert Uytterhoeven <geert@linux-m68k.org>
Cc:	Ralf Baechle <ralf@linux-mips.org>
---
 drivers/auxdisplay/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- lnx-410-rc2.orig/drivers/auxdisplay/Kconfig
+++ lnx-410-rc2/drivers/auxdisplay/Kconfig
@@ -121,6 +121,7 @@ config CFAG12864B_RATE
 
 config IMG_ASCII_LCD
 	tristate "Imagination Technologies ASCII LCD Display"
+	depends on HAS_IOMEM
 	default y if MIPS_MALTA || MIPS_SEAD3
 	select SYSCON
 	help


             reply	other threads:[~2017-01-02  2:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-02  2:42 Randy Dunlap [this message]
2017-01-02  8:32 ` [PATCH] auxdisplay: img-ascii-lcd: don't build without HAS_IOMEM Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81455897-f6c1-79c1-7410-eff7656c1a0f@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=arnd@arndb.de \
    --cc=fengguang.wu@intel.com \
    --cc=geert@linux-m68k.org \
    --cc=jdike@addtoit.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul.burton@imgtec.com \
    --cc=ralf@linux-mips.org \
    --cc=richard@nod.at \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).