From: Richard Weinberger <richard@nod.at>
To: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Cc: linux-um@lists.infradead.org
Subject: Re: [PATCH] um: Try to avoid kmalloc in signal handling
Date: Thu, 03 Jan 2019 22:42:45 +0100 [thread overview]
Message-ID: <8232816.4fJl4d8jsT@blindfold> (raw)
In-Reply-To: <da88ec54-3d0b-360a-863d-59e29c8eaa00@cambridgegreys.com>
Am Donnerstag, 3. Januar 2019, 22:29:17 CET schrieb Anton Ivanov:
> Second thought - this should not use kmalloc at all if it can. It should
> either go on the stack the way it used to do before
> b6024b21fec8367ef961a771cc9dde31f1831965 or it should have a sufficient
> "register stack" to push registers for all use cases.
>
> Kmalloc/ATOMIC can fail just because it feels like it which means that
> this can throw a panic() under very heavy IO.
Not good. :-(
We cannot go back to stack based allocation. The stack is too small for
AVX register sets.
Maybe we can preallocate it.
(And check what arch/x86/ does)
Thanks,
//richard
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2019-01-03 21:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 16:09 [PATCH] um: Try to avoid kmalloc in signal handling anton.ivanov
2019-01-03 17:13 ` Anton Ivanov
2019-01-03 21:29 ` Anton Ivanov
2019-01-03 21:42 ` Richard Weinberger [this message]
2019-01-04 7:07 ` Anton Ivanov
2019-01-04 7:48 ` Anton Ivanov
2019-01-04 15:50 ` Anton Ivanov
2019-01-07 10:07 ` Anton Ivanov
-- strict thread matches above, loose matches on Subject: below --
2019-01-04 10:05 anton.ivanov
2019-01-04 10:13 ` Richard Weinberger
2019-01-04 10:19 ` Anton Ivanov
2019-01-04 10:33 ` Richard Weinberger
2019-01-04 10:49 ` Anton Ivanov
2019-01-04 11:31 ` Anton Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8232816.4fJl4d8jsT@blindfold \
--to=richard@nod.at \
--cc=anton.ivanov@cambridgegreys.com \
--cc=linux-um@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox