* Re: [PATCH v9 13/28] um: Annotate data appropriately
2019-10-11 11:50 ` [PATCH v9 13/28] um: Annotate data appropriately Jiri Slaby
@ 2019-10-15 15:37 ` Richard Weinberger
2019-10-18 16:30 ` [tip: x86/asm] x86/um: " tip-bot2 for Jiri Slaby
1 sibling, 0 replies; 3+ messages in thread
From: Richard Weinberger @ 2019-10-15 15:37 UTC (permalink / raw)
To: Jiri Slaby
Cc: bp, tglx, mingo, hpa, x86, linux-arch, linux-kernel, Jeff Dike,
user-mode-linux-devel, user-mode-linux-user
----- Ursprüngliche Mail -----
> Von: "Jiri Slaby" <jslaby@suse.cz>
> An: bp@alien8.de
> CC: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, linux-arch@vger.kernel.org, "linux-kernel"
> <linux-kernel@vger.kernel.org>, "Jiri Slaby" <jslaby@suse.cz>, "Jeff Dike" <jdike@addtoit.com>, "richard"
> <richard@nod.at>, user-mode-linux-devel@lists.sourceforge.net, user-mode-linux-user@lists.sourceforge.net
> Gesendet: Freitag, 11. Oktober 2019 13:50:53
> Betreff: [PATCH v9 13/28] um: Annotate data appropriately
> Use the new SYM_DATA_START and SYM_DATA_END_LABEL macros for vdso_start.
>
> We get:
> 0000 2376 OBJECT GLOBAL DEFAULT 4 vdso_start
> 0948 0 OBJECT GLOBAL DEFAULT 4 vdso_end
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Jeff Dike <jdike@addtoit.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: x86@kernel.org
> Cc: user-mode-linux-devel@lists.sourceforge.net
> Cc: user-mode-linux-user@lists.sourceforge.net
> ---
> arch/x86/um/vdso/vdso.S | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/um/vdso/vdso.S b/arch/x86/um/vdso/vdso.S
> index a4a3870dc059..a6eaf293a73b 100644
> --- a/arch/x86/um/vdso/vdso.S
> +++ b/arch/x86/um/vdso/vdso.S
> @@ -1,11 +1,11 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> #include <linux/init.h>
> +#include <linux/linkage.h>
>
> __INITDATA
>
> - .globl vdso_start, vdso_end
> -vdso_start:
> +SYM_DATA_START(vdso_start)
> .incbin "arch/x86/um/vdso/vdso.so"
> -vdso_end:
> +SYM_DATA_END_LABEL(vdso_start, SYM_L_GLOBAL, vdso_end)
Acked-by: Richard Weinberger <richard@nod.at>
Thanks,
//richard
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip: x86/asm] x86/um: Annotate data appropriately
2019-10-11 11:50 ` [PATCH v9 13/28] um: Annotate data appropriately Jiri Slaby
2019-10-15 15:37 ` Richard Weinberger
@ 2019-10-18 16:30 ` tip-bot2 for Jiri Slaby
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Jiri Slaby @ 2019-10-18 16:30 UTC (permalink / raw)
To: linux-tip-commits
Cc: Jiri Slaby, Borislav Petkov, Richard Weinberger, Anton Ivanov,
H. Peter Anvin, Ingo Molnar, Jeff Dike, linux-arch, linux-um,
Thomas Gleixner, user-mode-linux-devel, user-mode-linux-user,
x86-ml, Ingo Molnar, Borislav Petkov, linux-kernel
The following commit has been merged into the x86/asm branch of tip:
Commit-ID: 773a37b182259f5e0cdb928112431b119a6e4500
Gitweb: https://git.kernel.org/tip/773a37b182259f5e0cdb928112431b119a6e4500
Author: Jiri Slaby <jslaby@suse.cz>
AuthorDate: Fri, 11 Oct 2019 13:50:53 +02:00
Committer: Borislav Petkov <bp@suse.de>
CommitterDate: Fri, 18 Oct 2019 10:45:03 +02:00
x86/um: Annotate data appropriately
Use the new SYM_DATA_START and SYM_DATA_END_LABEL macros for vdso_start.
Result is:
0000 2376 OBJECT GLOBAL DEFAULT 4 vdso_start
0948 0 OBJECT GLOBAL DEFAULT 4 vdso_end
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Borislav Petkov <bp@suse.de>
Acked-by: Richard Weinberger <richard@nod.at>
Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jeff Dike <jdike@addtoit.com>
Cc: linux-arch@vger.kernel.org
Cc: linux-um@lists.infradead.org
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: user-mode-linux-devel@lists.sourceforge.net
Cc: user-mode-linux-user@lists.sourceforge.net
Cc: x86-ml <x86@kernel.org>
Link: https://lkml.kernel.org/r/20191011115108.12392-14-jslaby@suse.cz
---
arch/x86/um/vdso/vdso.S | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/um/vdso/vdso.S b/arch/x86/um/vdso/vdso.S
index a4a3870..a6eaf29 100644
--- a/arch/x86/um/vdso/vdso.S
+++ b/arch/x86/um/vdso/vdso.S
@@ -1,11 +1,11 @@
/* SPDX-License-Identifier: GPL-2.0 */
#include <linux/init.h>
+#include <linux/linkage.h>
__INITDATA
- .globl vdso_start, vdso_end
-vdso_start:
+SYM_DATA_START(vdso_start)
.incbin "arch/x86/um/vdso/vdso.so"
-vdso_end:
+SYM_DATA_END_LABEL(vdso_start, SYM_L_GLOBAL, vdso_end)
__FINIT
^ permalink raw reply related [flat|nested] 3+ messages in thread