From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: jdike@addtoit.com
Cc: Martyn Welch <martyn@collabora.com>,
richard@nod.at, linux-um@lists.infradead.org,
kernel@collabora.com,
Christopher Obbard <chris.obbard@collabora.com>,
anton.ivanov@cambridgegreys.com
Subject: Re: [PATCH v2] um: ubd: Submit all data segments atomically
Date: Wed, 09 Dec 2020 10:56:01 -0300 [thread overview]
Message-ID: <87blf35bim.fsf@collabora.com> (raw)
In-Reply-To: <20201122041356.1454413-1-krisman@collabora.com> (Gabriel Krisman Bertazi's message of "Sat, 21 Nov 2020 23:13:56 -0500")
Gabriel Krisman Bertazi <krisman@collabora.com> writes:
> Internally, UBD treats each physical IO segment as a separate command to
> be submitted in the execution pipe. If the pipe returns a transient
> error after a few segments have already been written, UBD will tell the
> block layer to requeue the request, but there is no way to reclaim the
> segments already submitted. When a new attempt to dispatch the request
> is done, those segments already submitted will get duplicated, causing
> the WARN_ON below in the best case, and potentially data corruption.
[...]
> Cc: Christopher Obbard <chris.obbard@collabora.com>
> Reported-by: Martyn Welch <martyn@collabora.com>
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
> Tested-by: Christopher Obbard <chris.obbard@collabora.com>
> Acked-by: Anton Ivanov <anton.ivanov@cambridgegreys.com>
ping. :)
--
Gabriel Krisman Bertazi
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2020-12-09 13:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-22 4:13 [PATCH v2] um: ubd: Submit all data segments atomically Gabriel Krisman Bertazi
2020-12-09 13:56 ` Gabriel Krisman Bertazi [this message]
2020-12-10 22:31 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blf35bim.fsf@collabora.com \
--to=krisman@collabora.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=chris.obbard@collabora.com \
--cc=jdike@addtoit.com \
--cc=kernel@collabora.com \
--cc=linux-um@lists.infradead.org \
--cc=martyn@collabora.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox