From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 531D7C44501 for ; Wed, 8 Jul 2026 21:50:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vmuHxwYgqm1gQOMh7c/wvEC96VXO05kzD/lM2vW9atQ=; b=Wvq+8dT+wWGHoJnmlT/mQVhS1h JkqvbJgTwiB05mWGK1l9RDQ6qp3k7pz/F24+tVsFCALGcmV/lJF16yRK4F86qpNSxBeIgn+3VWBEp s5JlNj/R6gkrHvCxv+CGv0/O3bm3h3HQsd+ACxVnnTP3Gc/Kv1FD6YQjQ2Ooxqd2h03FeBGAiGlDm hy2p+5zry/+/SqgQhjifEp/GR8/3/2nytLRfz6amFrxJrpOIUFnDusbH81xJo3anqVqFW2TjL/k+F o8FSHT+TRvp6RKqw3gzMapotXPTR6OyyQ21o4B7r9UsbuXnxoktuqjCrHE4ixi2/blKuSk4JO9dgt UYwC1zVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wha9b-00000000T5q-1IHX; Wed, 08 Jul 2026 21:50:03 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wha9Z-00000000T5E-1EW5; Wed, 08 Jul 2026 21:50:01 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id B674B42B57; Wed, 8 Jul 2026 21:50:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6ADD1F000E9; Wed, 8 Jul 2026 21:49:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783547400; bh=vmuHxwYgqm1gQOMh7c/wvEC96VXO05kzD/lM2vW9atQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=LQXgoHnJBN1jyue5u35c/dE+tvbdFa3zUViq7zqGblJh/ZruG6J0COcocKehdLFfd 4xXw/bCoVIbrdpJZ1yxvDgT9U95yzkk950wT9I897knLqsLOwWpBR6zC0Wl0OmKtGN qA7xvyVuCxc36Uggfu07lBhQDGgG4EE5F0SW1Nvv4sJgy854Xef255mh0e3TvqBF2r SBr4Ish5mjPGiV3ozZVjDpPopq53Klt37AdVF1ulSRh47ns0ya3XPMuPgRNdRIF3jm 1AeWmFDRhRZWLT6auHwI3KvNlkgzOBPY9SYSho4DzEN/jTu7kl2ls2cvpTtmqLBfh9 CtbtIsoeAAukg== From: Thomas Gleixner To: Oleg Nesterov Cc: Jinjie Ruan , LKML , Peter Zijlstra , Mark Rutland , Kees Cook , Andy Lutomirski , Richard Henderson , Russell King , Catalin Marinas , Guo Ren , Geert Uytterhoeven , Thomas Bogendoerfer , Helge Deller , Yoshinori Sato , Richard Weinberger , Chris Zankel , linux-arm-kernel@lists.infradead.org, linux-alpha@vger.kernel.org, linux-csky@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, Michael Ellerman , Shrikanth Hegde , linuxppc-dev@lists.ozlabs.org, Huacai Chen , loongarch@lists.linux.dev, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Sven Schnelle , linux-s390@vger.kernel.org, x86@kernel.org, Arnd Bergmann , Vineet Gupta , Will Deacon , Brian Cain , Michal Simek , Dinh Nguyen , "David S. Miller" , Andreas Larsson , linux-snps-arc@lists.infradead.org, linux-hexagon@vger.kernel.org, linux-openrisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, Michal =?utf-8?Q?Such=C3=A1nek?= , Jonathan Corbet , linux-doc@vger.kernel.org Subject: Re: [patch 11/18] seccomp, treewide: Rename and convert __secure_computing() to return boolean In-Reply-To: References: <20260707181957.433213175@kernel.org> <20260707190254.230735780@kernel.org> <2e6ed364-ce8f-4b4b-8675-acd07f140f4f@huawei.com> <871pddsuzl.ffs@fw13> Date: Wed, 08 Jul 2026 23:49:57 +0200 Message-ID: <87pl0xqhh6.ffs@fw13> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org On Wed, Jul 08 2026 at 18:04, Oleg Nesterov wrote: > On 07/08, Thomas Gleixner wrote: >> >> On Wed, Jul 08 2026 at 09:43, Jinjie Ruan wrote: >> > >> > The return value of __seccomp_filter is checked in the wrong way, check >> > -1 should be replaced with check false, maybe: >> > >> > - if (__seccomp_filter(this_syscall, true)) >> > - return -1; >> > + if (!__seccomp_filter(this_syscall, true)) >> > + return false; > > Or simply > > return __seccomp_filter(this_syscall, true); > > and remove "return true" below ? Duh. Obvious now that you point it out :) > Either way, I personally like this change, I was always confused by these -1's. Welcome to the club!