Re: [PATCH v2 02/21] powerpc: use memblock functions returning virtual address

Michael Ellerman
2019-01-29T09:52:17Z

Mike Rapoport <rppt@linux.ibm.com> writes:

> From: Christophe Leroy <christophe.leroy@c-s.fr>
>
> Since only the virtual address of allocated blocks is used,
> lets use functions returning directly virtual address.
>
> Those functions have the advantage of also zeroing the block.
>
> [ MR:
> - updated error message in alloc_stack() to be more verbose
> - convereted several additional call sites ]
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
> ---
> arch/powerpc/kernel/dt_cpu_ftrs.c | 3 +--
> arch/powerpc/kernel/irq.c | 5 -----
> arch/powerpc/kernel/paca.c | 6 +++++-
> arch/powerpc/kernel/prom.c | 5 ++++-
> arch/powerpc/kernel/setup_32.c | 26 ++++++++++++++++----------
> 5 files changed, 26 insertions(+), 19 deletions(-)

LGTM.

Acked-by: Michael Ellerman <mpe@ellerman.id.au>

cheers