Re: [PATCH v2 1/3] arch: consolidate existing CONFIG_PAGE_SIZE_*KB definitions

Michael Ellerman
2024-03-06T23:41:29Z

Hi Arnd,

Arnd Bergmann <arnd@kernel.org> writes:
> From: Arnd Bergmann <arnd@arndb.de>
>
> These four architectures define the same Kconfig symbols for configuring
> the page size. Move the logic into a common place where it can be shared
> with all other architectures.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> Changes from v1:
> - improve Kconfig help texts
> - fix Hexagon Kconfig
>
> arch/Kconfig | 92 ++++++++++++++++++++++++++++++-
> arch/hexagon/Kconfig | 24 ++------
> arch/hexagon/include/asm/page.h | 6 +-
> arch/loongarch/Kconfig | 21 ++-----
> arch/loongarch/include/asm/page.h | 10 +---
> arch/mips/Kconfig | 58 ++-----------------
> arch/mips/include/asm/page.h | 16 +-----
> arch/sh/include/asm/page.h | 13 +----
> arch/sh/mm/Kconfig | 42 ++++----------
> 9 files changed, 121 insertions(+), 161 deletions(-)

There's a few "help" lines missing, which breaks the build:

arch/Kconfig:1134: syntax error
arch/Kconfig:1133: invalid statement
arch/Kconfig:1134: invalid statement
arch/Kconfig:1135:warning: ignoring unsupported character '.'
arch/Kconfig:1135:warning: ignoring unsupported character '.'
arch/Kconfig:1135: invalid statement
arch/Kconfig:1136: invalid statement
arch/Kconfig:1137:warning: ignoring unsupported character '.'
arch/Kconfig:1137: invalid statement
arch/Kconfig:1143: syntax error
arch/Kconfig:1142: invalid statement
arch/Kconfig:1143: invalid statement
arch/Kconfig:1144:warning: ignoring unsupported character '.'
arch/Kconfig:1144: invalid statement
arch/Kconfig:1145: invalid statement
arch/Kconfig:1146: invalid statement
arch/Kconfig:1147: invalid statement
arch/Kconfig:1148:warning: ignoring unsupported character '.'
arch/Kconfig:1148: invalid statement
make[4]: *** [../scripts/kconfig/Makefile:85: syncconfig] Error 1

Fixup diff is:

diff --git a/arch/Kconfig b/arch/Kconfig
index 56d45a75f625..f2295fa3b48c 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -1130,6 +1130,7 @@ config PAGE_SIZE_16KB
config PAGE_SIZE_32KB
bool "32KiB pages"
depends on HAVE_PAGE_SIZE_32KB
+ help
Using 32KiB page size will result in slightly higher performance
kernel at the price of higher memory consumption compared to
16KiB pages. This option is available only on cnMIPS cores.
@@ -1139,6 +1140,7 @@ config PAGE_SIZE_32KB
config PAGE_SIZE_64KB
bool "64KiB pages"
depends on HAVE_PAGE_SIZE_64KB
+ help
Using 64KiB page size will result in slightly higher performance
kernel at the price of much higher memory consumption compared to
4KiB or 16KiB pages.

cheers