[PATCH v2] drivers: use free_netdev before return

[PATCH v2] drivers: use free_netdev before return

[Minjie Du]

We will replace the old version of 
undo_user_init and use out_free_netdev

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 arch/um/drivers/vector_kern.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c
index af7f6fd4c..7ae6ab8df 100644
--- a/arch/um/drivers/vector_kern.c
+++ b/arch/um/drivers/vector_kern.c
@@ -1646,7 +1646,7 @@ static void vector_eth_configure(
 	err = register_netdevice(dev);
 	rtnl_unlock();
 	if (err)
-		goto out_undo_user_init;
+		goto out_free_netdev;
 
 	spin_lock(&vector_devices_lock);
 	list_add(&device->list, &vector_devices);
@@ -1654,9 +1654,6 @@ static void vector_eth_configure(
 
 	return;
 
-out_undo_user_init:
-	free_netdev(dev);
-	return;
 out_free_netdev:
 	free_netdev(dev);
 out_free_device:
-- 
2.39.0


_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um

Re: [PATCH v2] drivers: use free_netdev before return

[Anton Ivanov]

On 03/07/2023 14:11, Minjie Du wrote:
> We will replace the old version of
> undo_user_init and use out_free_netdev
> 
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
>   arch/um/drivers/vector_kern.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c
> index af7f6fd4c..7ae6ab8df 100644
> --- a/arch/um/drivers/vector_kern.c
> +++ b/arch/um/drivers/vector_kern.c
> @@ -1646,7 +1646,7 @@ static void vector_eth_configure(
>   	err = register_netdevice(dev);
>   	rtnl_unlock();
>   	if (err)
> -		goto out_undo_user_init;
> +		goto out_free_netdev;
>   
>   	spin_lock(&vector_devices_lock);
>   	list_add(&device->list, &vector_devices);
> @@ -1654,9 +1654,6 @@ static void vector_eth_configure(
>   
>   	return;
>   
> -out_undo_user_init:
> -	free_netdev(dev);
> -	return;
>   out_free_netdev:
>   	free_netdev(dev);
>   out_free_device:

Acked-By: "Anton Ivanov" <anton.ivanov@cambridgegreys.com>

-- 
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/

_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um

Re: [PATCH v2] drivers: use free_netdev before return in vector_eth_configure()

[Markus Elfring]

Would the information “um: vector: …” be more appropriate
for the subsystem specification in the patch subject?



> We will replace the old version of
> undo_user_init and use out_free_netdev

Please choose a better imperative change suggestion.

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n94


How do you think about to add the tag “Fixes”?

Regards,
Markus

_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um