linux-um.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: user-mode-linux-devel@lists.sourceforge.net,
	user-mode-linux-user@lists.sourceforge.net,
	Anton Ivanov <aivanov@kot-begemot.co.uk>,
	Dan Williams <dan.j.williams@intel.com>,
	Hannes Reinecke <hare@suse.com>, Jeff Dike <jdike@addtoit.com>,
	Jens Axboe <axboe@fb.com>, Richard Weinberger <richard@nod.at>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 5/5] um: ubd: Improve size determinations in do_ubd_request()
Date: Wed, 18 Jan 2017 23:00:08 +0100	[thread overview]
Message-ID: <8a539d85-ff17-296c-75be-913731c2febc@users.sourceforge.net> (raw)
In-Reply-To: <c10b7f33-f573-aa9f-239e-ccca5540f264@users.sourceforge.net>

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 18 Jan 2017 22:38:04 +0100

Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 arch/um/drivers/ubd_kern.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c
index 6d686f735538..50327d5a9a01 100644
--- a/arch/um/drivers/ubd_kern.c
+++ b/arch/um/drivers/ubd_kern.c
@@ -1386,8 +1386,7 @@ static void do_ubd_request(struct request_queue *q)
 		req = dev->request;
 
 		if (req_op(req) == REQ_OP_FLUSH) {
-			io_req = kmalloc(sizeof(struct io_thread_req),
-					 GFP_ATOMIC);
+			io_req = kmalloc(sizeof(*io_req), GFP_ATOMIC);
 			if (io_req == NULL) {
 				if (list_empty(&dev->restart))
 					list_add(&dev->restart, &restart);
@@ -1401,8 +1400,7 @@ static void do_ubd_request(struct request_queue *q)
 		while(dev->start_sg < dev->end_sg){
 			struct scatterlist *sg = &dev->sg[dev->start_sg];
 
-			io_req = kmalloc(sizeof(struct io_thread_req),
-					 GFP_ATOMIC);
+			io_req = kmalloc(sizeof(*io_req), GFP_ATOMIC);
 			if(io_req == NULL){
 				if(list_empty(&dev->restart))
 					list_add(&dev->restart, &restart);
-- 
2.11.0



  parent reply	other threads:[~2017-01-18 22:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-18 21:55 [PATCH 0/5] UM: Fine-tuning for some function implementations SF Markus Elfring
2017-01-18 21:56 ` [PATCH 1/5] um: port: Move an assignment for the variable "fd" in port_wait() SF Markus Elfring
2017-01-19  0:03   ` Jeff Dike
2017-01-18 21:57 ` [PATCH 2/5] um: port: Delete three error messages for a failed memory allocation SF Markus Elfring
2017-01-19  0:07   ` Jeff Dike
2017-01-19  9:38     ` SF Markus Elfring
2017-01-18 21:58 ` [PATCH 3/5] um: port: Improve size determinations in port_data() SF Markus Elfring
2017-01-18 21:59 ` [PATCH 4/5] um: ubd: Move two assignments for the variable "err" in ubd_remove() SF Markus Elfring
2017-01-18 22:00 ` SF Markus Elfring [this message]
2017-01-19  7:56 ` [PATCH 0/5] UM: Fine-tuning for some function implementations Richard Weinberger
2017-01-19 17:13   ` SF Markus Elfring
2017-01-19 18:44     ` Anton Ivanov
2017-01-20  5:11   ` [PATCH 0/5] " Jeff Dike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a539d85-ff17-296c-75be-913731c2febc@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=aivanov@kot-begemot.co.uk \
    --cc=axboe@fb.com \
    --cc=dan.j.williams@intel.com \
    --cc=hare@suse.com \
    --cc=jdike@addtoit.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richard@nod.at \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    --cc=user-mode-linux-user@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).