From: Anton Ivanov <anton.ivanov@cambridgegreys.com>
To: Tiwei Bie <tiwei.btw@antgroup.com>,
richard@nod.at, johannes@sipsolutions.net
Cc: linux-um@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] um: ubd: Initialize ubd's disk pointer in ubd_add
Date: Mon, 4 Nov 2024 16:55:13 +0000 [thread overview]
Message-ID: <8b4f592c-bdc9-4a2b-bf97-afe11b840d4b@cambridgegreys.com> (raw)
In-Reply-To: <20241104163203.435515-2-tiwei.btw@antgroup.com>
On 04/11/2024 16:32, Tiwei Bie wrote:
> Currently, the initialization of the disk pointer in the ubd structure
> is missing. It should be initialized with the allocated gendisk pointer
> in ubd_add().
>
> Fixes: 32621ad7a7ea ("ubd: remove the ubd_gendisk array")
> Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com>
> ---
> arch/um/drivers/ubd_kern.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c
> index 2b8d04e67600..f19173da64d8 100644
> --- a/arch/um/drivers/ubd_kern.c
> +++ b/arch/um/drivers/ubd_kern.c
> @@ -898,6 +898,8 @@ static int ubd_add(int n, char **error_out)
> if (err)
> goto out_cleanup_disk;
>
> + ubd_dev->disk = disk;
> +
> return 0;
>
> out_cleanup_disk:
Acked-By: Anton Ivanov <anton.ivanov@cambridgegreys.com>
--
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/
next prev parent reply other threads:[~2024-11-04 18:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 16:31 [PATCH 0/4] um: Some minor driver fixes Tiwei Bie
2024-11-04 16:32 ` [PATCH 1/4] um: ubd: Initialize ubd's disk pointer in ubd_add Tiwei Bie
2024-11-04 16:55 ` Anton Ivanov [this message]
2024-11-04 16:32 ` [PATCH 2/4] um: ubd: Do not use drvdata in release Tiwei Bie
2024-11-04 16:54 ` Anton Ivanov
2024-11-04 16:32 ` [PATCH 3/4] um: net: " Tiwei Bie
2024-11-04 16:54 ` Anton Ivanov
2024-11-04 16:32 ` [PATCH 4/4] um: vector: " Tiwei Bie
2024-11-04 16:53 ` Anton Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b4f592c-bdc9-4a2b-bf97-afe11b840d4b@cambridgegreys.com \
--to=anton.ivanov@cambridgegreys.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
--cc=tiwei.btw@antgroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox