From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ne7BL-00BQFi-2k for linux-um@lists.infradead.org; Tue, 12 Apr 2022 03:27:08 +0000 Received: by mail-pj1-f71.google.com with SMTP id r12-20020a17090a690c00b001cb9bce2284so2389572pjj.8 for ; Mon, 11 Apr 2022 20:27:04 -0700 (PDT) Message-ID: <927ee895-84ae-fb69-c9ed-9c1836ff1d03@redhat.com> Date: Tue, 12 Apr 2022 11:26:49 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v9 07/32] virtio_ring: split: extract the logic of alloc state and extra References: <20220406034346.74409-1-xuanzhuo@linux.alibaba.com> <20220406034346.74409-8-xuanzhuo@linux.alibaba.com> From: Jason Wang In-Reply-To: <20220406034346.74409-8-xuanzhuo@linux.alibaba.com> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Xuan Zhuo , virtualization@lists.linux-foundation.org Cc: Jeff Dike , Richard Weinberger , Anton Ivanov , "Michael S. Tsirkin" , "David S. Miller" , Jakub Kicinski , Hans de Goede , Mark Gross , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Alexander Gordeev , Sven Schnelle , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Johannes Berg , Vincent Whitchurch , linux-um@lists.infradead.org, netdev@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, bpf@vger.kernel.org CuWcqCAyMDIyLzQvNiDkuIrljYgxMTo0MywgWHVhbiBaaHVvIOWGmemBkzoKPiBTZXBhcmF0ZSB0 aGUgbG9naWMgb2YgY3JlYXRpbmcgZGVzY19zdGF0ZSwgZGVzY19leHRyYSwgYW5kIHN1YnNlcXVl bnQKPiBwYXRjaGVzIHdpbGwgY2FsbCBpdCBpbmRlcGVuZGVudGx5Lgo+Cj4gU2lnbmVkLW9mZi1i eTogWHVhbiBaaHVvIDx4dWFuemh1b0BsaW51eC5hbGliYWJhLmNvbT4KPiAtLS0KPiAgIGRyaXZl cnMvdmlydGlvL3ZpcnRpb19yaW5nLmMgfCA1MyArKysrKysrKysrKysrKysrKysrKysrKysrKy0t LS0tLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAzOCBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlv bnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3ZpcnRpby92aXJ0aW9fcmluZy5jIGIvZHJp dmVycy92aXJ0aW8vdmlydGlvX3JpbmcuYwo+IGluZGV4IDcyZDVhZTA2M2ZhMC4uNmRlNjc0Mzlj YjU3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvdmlydGlvL3ZpcnRpb19yaW5nLmMKPiArKysgYi9k cml2ZXJzL3ZpcnRpby92aXJ0aW9fcmluZy5jCj4gQEAgLTE5OCw2ICsxOTgsNyBAQCBzdHJ1Y3Qg dnJpbmdfdmlydHF1ZXVlIHsKPiAgICNlbmRpZgo+ICAgfTsKPiAgIAo+ICtzdGF0aWMgc3RydWN0 IHZyaW5nX2Rlc2NfZXh0cmEgKnZyaW5nX2FsbG9jX2Rlc2NfZXh0cmEodW5zaWduZWQgaW50IG51 bSk7Cj4gICAKPiAgIC8qCj4gICAgKiBIZWxwZXJzLgo+IEBAIC05MTUsNiArOTE2LDMzIEBAIHN0 YXRpYyB2b2lkICp2aXJ0cXVldWVfZGV0YWNoX3VudXNlZF9idWZfc3BsaXQoc3RydWN0IHZpcnRx dWV1ZSAqX3ZxKQo+ICAgCXJldHVybiBOVUxMOwo+ICAgfQo+ICAgCj4gK3N0YXRpYyBpbnQgdnJp bmdfYWxsb2Nfc3RhdGVfZXh0cmFfc3BsaXQodTMyIG51bSwKPiArCQkJCQkgc3RydWN0IHZyaW5n X2Rlc2Nfc3RhdGVfc3BsaXQgKipkZXNjX3N0YXRlLAo+ICsJCQkJCSBzdHJ1Y3QgdnJpbmdfZGVz Y19leHRyYSAqKmRlc2NfZXh0cmEpCj4gK3sKPiArCXN0cnVjdCB2cmluZ19kZXNjX3N0YXRlX3Nw bGl0ICpzdGF0ZTsKPiArCXN0cnVjdCB2cmluZ19kZXNjX2V4dHJhICpleHRyYTsKPiArCj4gKwlz dGF0ZSA9IGttYWxsb2NfYXJyYXkobnVtLCBzaXplb2Yoc3RydWN0IHZyaW5nX2Rlc2Nfc3RhdGVf c3BsaXQpLCBHRlBfS0VSTkVMKTsKPiArCWlmICghc3RhdGUpCj4gKwkJZ290byBlcnJfc3RhdGU7 Cj4gKwo+ICsJZXh0cmEgPSB2cmluZ19hbGxvY19kZXNjX2V4dHJhKG51bSk7Cj4gKwlpZiAoIWV4 dHJhKQo+ICsJCWdvdG8gZXJyX2V4dHJhOwo+ICsKPiArCW1lbXNldChzdGF0ZSwgMCwgbnVtICog c2l6ZW9mKHN0cnVjdCB2cmluZ19kZXNjX3N0YXRlX3NwbGl0KSk7Cj4gKwo+ICsJKmRlc2Nfc3Rh dGUgPSBzdGF0ZTsKPiArCSpkZXNjX2V4dHJhID0gZXh0cmE7Cj4gKwlyZXR1cm4gMDsKPiArCj4g K2Vycl9leHRyYToKPiArCWtmcmVlKHN0YXRlKTsKPiArZXJyX3N0YXRlOgo+ICsJcmV0dXJuIC1F Tk9NRU07Cj4gK30KPiArCj4gICBzdGF0aWMgdm9pZCAqdnJpbmdfYWxsb2NfcXVldWVfc3BsaXQo c3RydWN0IHZpcnRpb19kZXZpY2UgKnZkZXYsCj4gICAJCQkJICAgICBkbWFfYWRkcl90ICpkbWFf YWRkciwKPiAgIAkJCQkgICAgIHUzMiAqbiwKPiBAQCAtMjE5Niw3ICsyMjI0LDEwIEBAIHN0cnVj dCB2aXJ0cXVldWUgKl9fdnJpbmdfbmV3X3ZpcnRxdWV1ZSh1bnNpZ25lZCBpbnQgaW5kZXgsCj4g ICAJCQkJCXZvaWQgKCpjYWxsYmFjaykoc3RydWN0IHZpcnRxdWV1ZSAqKSwKPiAgIAkJCQkJY29u c3QgY2hhciAqbmFtZSkKPiAgIHsKPiArCXN0cnVjdCB2cmluZ19kZXNjX3N0YXRlX3NwbGl0ICpz dGF0ZTsKPiArCXN0cnVjdCB2cmluZ19kZXNjX2V4dHJhICpleHRyYTsKPiAgIAlzdHJ1Y3QgdnJp bmdfdmlydHF1ZXVlICp2cTsKPiArCWludCBlcnI7Cj4gICAKPiAgIAlpZiAodmlydGlvX2hhc19m ZWF0dXJlKHZkZXYsIFZJUlRJT19GX1JJTkdfUEFDS0VEKSkKPiAgIAkJcmV0dXJuIE5VTEw7Cj4g QEAgLTIyNDYsMzAgKzIyNzcsMjIgQEAgc3RydWN0IHZpcnRxdWV1ZSAqX192cmluZ19uZXdfdmly dHF1ZXVlKHVuc2lnbmVkIGludCBpbmRleCwKPiAgIAkJCQkJdnEtPnNwbGl0LmF2YWlsX2ZsYWdz X3NoYWRvdyk7Cj4gICAJfQo+ICAgCj4gLQl2cS0+c3BsaXQuZGVzY19zdGF0ZSA9IGttYWxsb2Nf YXJyYXkodnJpbmcubnVtLAo+IC0JCQlzaXplb2Yoc3RydWN0IHZyaW5nX2Rlc2Nfc3RhdGVfc3Bs aXQpLCBHRlBfS0VSTkVMKTsKPiAtCWlmICghdnEtPnNwbGl0LmRlc2Nfc3RhdGUpCj4gLQkJZ290 byBlcnJfc3RhdGU7Cj4gKwllcnIgPSB2cmluZ19hbGxvY19zdGF0ZV9leHRyYV9zcGxpdCh2cmlu Zy5udW0sICZzdGF0ZSwgJmV4dHJhKTsKCgpOaXQ6IHdlIGNhbiBwYXNzIGUuZyAmdnEtPnNwbGl0 LmRlc2Nfc3RhdGUgaGVyZSB0byBhdm9pZCBleHRyYSB0ZW1wIAp2YXJpYWJsZSBhbmQgYXNzaWdu bWVudC4KCk90aGVyIGxvb2tzIGdvb2QuCgpUaGFua3MKCgo+ICsJaWYgKGVycikgewo+ICsJCWtm cmVlKHZxKTsKPiArCQlyZXR1cm4gTlVMTDsKPiArCX0KPiAgIAo+IC0JdnEtPnNwbGl0LmRlc2Nf ZXh0cmEgPSB2cmluZ19hbGxvY19kZXNjX2V4dHJhKHZyaW5nLm51bSk7Cj4gLQlpZiAoIXZxLT5z cGxpdC5kZXNjX2V4dHJhKQo+IC0JCWdvdG8gZXJyX2V4dHJhOwo+ICsJdnEtPnNwbGl0LmRlc2Nf c3RhdGUgPSBzdGF0ZTsKPiArCXZxLT5zcGxpdC5kZXNjX2V4dHJhID0gZXh0cmE7Cj4gICAKPiAg IAkvKiBQdXQgZXZlcnl0aGluZyBpbiBmcmVlIGxpc3RzLiAqLwo+ICAgCXZxLT5mcmVlX2hlYWQg PSAwOwo+IC0JbWVtc2V0KHZxLT5zcGxpdC5kZXNjX3N0YXRlLCAwLCB2cmluZy5udW0gKgo+IC0J CQlzaXplb2Yoc3RydWN0IHZyaW5nX2Rlc2Nfc3RhdGVfc3BsaXQpKTsKPiAgIAo+ICAgCXNwaW5f bG9jaygmdmRldi0+dnFzX2xpc3RfbG9jayk7Cj4gICAJbGlzdF9hZGRfdGFpbCgmdnEtPnZxLmxp c3QsICZ2ZGV2LT52cXMpOwo+ICAgCXNwaW5fdW5sb2NrKCZ2ZGV2LT52cXNfbGlzdF9sb2NrKTsK PiAgIAlyZXR1cm4gJnZxLT52cTsKPiAtCj4gLWVycl9leHRyYToKPiAtCWtmcmVlKHZxLT5zcGxp dC5kZXNjX3N0YXRlKTsKPiAtZXJyX3N0YXRlOgo+IC0Ja2ZyZWUodnEpOwo+IC0JcmV0dXJuIE5V TEw7Cj4gICB9Cj4gICBFWFBPUlRfU1lNQk9MX0dQTChfX3ZyaW5nX25ld192aXJ0cXVldWUpOwo+ ICAgCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtdW0gbWFpbGluZyBsaXN0CmxpbnV4LXVtQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC11bQo=