From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 238E4C02190 for ; Tue, 21 Jan 2025 16:07:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To:Subject: Message-ID:Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FIGX2U5Y620ytLuHZv9C2YKRXU6LkFVVh5lOzeeXil4=; b=ip9fQSjny+zNHgtMERr341i+bk 1TFlEAfmVYfbVWfCp0o0aSUK0U3i8/tNnK28ia2+HpZ+wxH9PRdV40j03/cQ2P98ccsnOSZvmAepI fbVRDusVKctVJUu7CqOEVA62UEJKODVyK7djWhwuoovCyxzOHRVDCQKMk72BdOgKZxbzCsCqfnYW+ NqJvlZVDF+N+HrmZSsWwAJRNqmIa1oXPdfQ79hytX8z+UmP08gMo9dEi0RgZP93e7yYHW5pldgDfW dNU/Y2+NAuPbTMBM7/FmPdaLJrlWb0LqRTttXv1mcitmLqf4K9KW6egGbzT1QKiz1dDtRLTbQXU34 +972pBJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1taGn7-00000008Jpf-3jSl; Tue, 21 Jan 2025 16:07:49 +0000 Received: from mail-qt1-x835.google.com ([2607:f8b0:4864:20::835]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tYkRy-000000008an-3l6y for linux-um@lists.infradead.org; Fri, 17 Jan 2025 11:23:45 +0000 Received: by mail-qt1-x835.google.com with SMTP id d75a77b69052e-467896541e1so208401cf.0 for ; Fri, 17 Jan 2025 03:23:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1737113021; x=1737717821; darn=lists.infradead.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=FIGX2U5Y620ytLuHZv9C2YKRXU6LkFVVh5lOzeeXil4=; b=UFe4hLvEJKAkTiTGNIKvQk9rLY9H59ruyM7J/0KJBRgxGDX9filmHPj47EbgcpsZTk Q9cG/TSeUxSjFq98kBRqORtrBdNzP8f7uqSJnrHyA0UVYlICNVCMhrhpCcdA2KXxaiNe mj07c9YbnpSbYl5m0nhAv+rr/XoGlzzHue2/WgVfuBMRakic9R68Z00Lp4KztTKCyD+P PkGIQ+LKlsZGjVGU9eK+GYTZondC32bDOOqHt6XLGvw6Fpm0Yi89L2JTb+qFOdpKop4l alHfHEInjxZ8Y7fzCCxqvzC1RpDjaEsbcCbHk8NZXdRKaPYzP05FfKMHUVvX097D1u7C JWWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737113021; x=1737717821; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FIGX2U5Y620ytLuHZv9C2YKRXU6LkFVVh5lOzeeXil4=; b=FHITehxjxaQv2owZvNQ7A5G10ZX6bZMeIM4RcbqfT+1wtQ2P8/pyCRJDGRwn0feMcQ PaTtog84IZ52PeAzSpkWo987mFA6vagCqa9f9JE4COLL1p2byE9Zm7OQufQAg/cuqm+i eZTWGiOnS5tRJWz6Vu0yP0bV+jbDumHsRCsFOaUH3QrJluAfpgSGZe4WuoSSYBxJs9RN nXAVzVWw10XwrJ2TB1ufWtBey88gH/vAmp6LicY+2H+pn+CllYFaitotPdG8rmo3JPBV 3tajDK2FDRobZKF2UCpoIwF8PgCfzfrnBwKFz2UiBTMRQBMRL1kn3Emp2u5jeVRAymzm sdNw== X-Forwarded-Encrypted: i=1; AJvYcCUpX0RZ83gyjqrsPFmYv8Ex3lwvG+RWYwIqFL93ggq7bB/5FAjvB0r5v0X9z1aLtbbaF1ae3V648w==@lists.infradead.org X-Gm-Message-State: AOJu0Yz/e/SCsmHS4v5l9VcGSoP8RzfdgLr4bHBv9VSjq1P3TgNaiz7h ba7F/IVamEMdgHRRDcqnxSHRmt7aAX6YHiJIVuUToBkPkitiaWfzD6NAGzlrzdmYAQl3bC2wlmx wVSi+XvX219VO9PiscTERFUpxmBjOWz3FV1s1 X-Gm-Gg: ASbGnct3Dd63Zu3pZNDqgTJ5MedhbjN46hTuowh3q9OhuqudLYp1HrieXfWkgFKctbN AyI3PKLNywfnQdpOMdXxUc+YHoYSN5Vy9UOXVrzhxsm8CBi7RO9YHf/MT50o9TFcmpekS X-Google-Smtp-Source: AGHT+IGncYyjy1GhHnzrsXOo74WzCLmIKZegqTWM730ikUDOlazbTaQH35QB0zgmvzL1yJ283cNPWINqKuKsZStNP0A= X-Received: by 2002:a05:622a:1997:b0:466:923f:a749 with SMTP id d75a77b69052e-46e130af265mr2539121cf.15.1737113021050; Fri, 17 Jan 2025 03:23:41 -0800 (PST) MIME-Version: 1.0 References: <20250110-asi-rfc-v2-v2-0-8419288bc805@google.com> <20250110-asi-rfc-v2-v2-16-8419288bc805@google.com> In-Reply-To: <20250110-asi-rfc-v2-v2-16-8419288bc805@google.com> From: Brendan Jackman Date: Fri, 17 Jan 2025 12:23:30 +0100 X-Gm-Features: AbW1kvZ_KaymUoc5jGYX-groCnX_p-Tg9PrSiJ2rBOnB_iSLYbhJZulsHf6-rd0 Message-ID: Subject: Re: [PATCH RFC v2 16/29] mm: asi: Map kernel text and static data as nonsensitive To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Richard Henderson , Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Brian Cain , Huacai Chen , WANG Xuerui , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Chris Zankel , Max Filippov , Arnd Bergmann , Andrew Morton , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Uladzislau Rezki , Christoph Hellwig , Masami Hiramatsu , Mathieu Desnoyers , Mike Rapoport , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Dennis Zhou , Tejun Heo , Christoph Lameter , Sean Christopherson , Paolo Bonzini , Ard Biesheuvel , Josh Poimboeuf , Pawan Gupta Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250117_032342_944202_2417C391 X-CRM114-Status: GOOD ( 12.38 ) X-Mailman-Approved-At: Tue, 21 Jan 2025 08:07:46 -0800 X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org On Fri, 10 Jan 2025 at 19:41, Brendan Jackman wrote: > + asi_clone_pgd(asi_global_nonsensitive_pgd, init_mm.pgd, VMEMMAP_START); > + asi_clone_pgd(asi_global_nonsensitive_pgd, init_mm.pgd, > + VMEMMAP_START + (1UL << PGDIR_SHIFT)); There's a bug here that Yosry has fixed in our internal version, I neglected to incorporate that here. Under KASLR, vmemmap is not necessarily exactly 2 PGDs like this is assuming. In fact it can share a PGD entry with the vmalloc area. So to be correct this cloning logic needs to actually look at the alignment and then navigate the page table hierarchy appropriately. To be fixed for the next version. As Yosry noted internally we also need to think about vmmemap getting updated under memory hotplug.