From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hfu8E-0005Xm-FE for linux-um@lists.infradead.org; Tue, 25 Jun 2019 22:41:43 +0000 Received: by mail-pl1-x643.google.com with SMTP id g4so225928plb.5 for ; Tue, 25 Jun 2019 15:41:41 -0700 (PDT) MIME-Version: 1.0 References: <20190617082613.109131-1-brendanhiggins@google.com> <20190617082613.109131-7-brendanhiggins@google.com> <20190625221318.GO19023@42.do-not-panic.com> In-Reply-To: <20190625221318.GO19023@42.do-not-panic.com> From: Brendan Higgins Date: Tue, 25 Jun 2019 15:41:29 -0700 Message-ID: Subject: Re: [PATCH v5 06/18] kbuild: enable building KUnit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Luis Chamberlain Cc: Petr Mladek , "open list:DOCUMENTATION" , Peter Zijlstra , Amir Goldstein , dri-devel , Sasha Levin , Masahiro Yamada , Michael Ellerman , "open list:KERNEL SELFTEST FRAMEWORK" , shuah , Rob Herring , linux-nvdimm , Frank Rowand , Knut Omang , Kieran Bingham , wfg@linux.intel.com, Joel Stanley , David Rientjes , Jeff Dike , Dan Carpenter , devicetree , linux-kbuild , "Bird, Timothy , linux-um@lists.infradead.org, Steven Rostedt" , Julia Lawall , Josh Poimboeuf , kunit-dev@googlegroups.com, Theodore Ts'o , Richard Weinberger , Stephen Boyd , Greg KH , Randy Dunlap , Linux Kernel Mailing List , Daniel Vetter , Kees Cook , linux-fsdevel@vger.kernel.org, Logan Gunthorpe , Kevin Hilman On Tue, Jun 25, 2019 at 3:13 PM Luis Chamberlain wrote: > > On Mon, Jun 17, 2019 at 01:26:01AM -0700, Brendan Higgins wrote: > > diff --git a/Kconfig b/Kconfig > > index 48a80beab6853..10428501edb78 100644 > > --- a/Kconfig > > +++ b/Kconfig > > @@ -30,3 +30,5 @@ source "crypto/Kconfig" > > source "lib/Kconfig" > > > > source "lib/Kconfig.debug" > > + > > +source "kunit/Kconfig" > > This patch would break compilation as kunit/Kconfig is not introduced. This > would would also break bisectability on this commit. This change should > either be folded in to the next patch, or just be a separate patch after > the next one. Maybe my brain isn't working right now, but I am pretty darn sure that I introduce kunit/Kconfig in the very first patch of this series. Quoting from the change summary from the first commit: > include/kunit/test.h | 161 +++++++++++++++++++++++++++++++++ > kunit/Kconfig | 17 ++++ > kunit/Makefile | 1 + > kunit/test.c | 210 +++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 389 insertions(+) > create mode 100644 include/kunit/test.h > create mode 100644 kunit/Kconfig I am not crazy, right? > create mode 100644 kunit/Makefile > create mode 100644 kunit/test.c _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um