From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: <6396875c-146a-acf5-dd9e-7f93ba1b4bc3@csgroup.eu> References: <20221006165346.73159-1-Jason@zx2c4.com> <20221006165346.73159-4-Jason@zx2c4.com> <848ed24c-13ef-6c38-fd13-639b33809194@csgroup.eu> <6396875c-146a-acf5-dd9e-7f93ba1b4bc3@csgroup.eu> From: "Jason A. Donenfeld" Date: Thu, 6 Oct 2022 17:36:48 -0600 Message-ID: Subject: Re: [PATCH v3 3/5] treewide: use get_random_u32() when possible List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Christophe Leroy Cc: "linux-kernel@vger.kernel.org" , "patches@lists.linux.dev" , Andreas Noever , Andrew Morton , Andy Shevchenko , Borislav Petkov , Catalin Marinas , =?UTF-8?Q?Christoph_B=C3=B6hmwalder?= , Christoph Hellwig , Daniel Borkmann , Dave Airlie , Dave Hansen , "David S . Miller" , Eric Dumazet , Florian Westphal , Greg Kroah-Hartman , "H . Peter Anvin" , Heiko Carstens , Helge Deller , Herbert Xu , Huacai Chen , Hugh Dickins , Jakub Kicinski , "James E . J . Bottomley" , Jan Kara , Jason Gunthorpe , Jens Axboe , Johannes Berg , Jonathan Corbet , Jozsef Kadlecsik , KP Singh , Kees Cook , Marco Elver , Mauro Carvalho Chehab , Michael Ellerman , Pablo Neira Ayuso , Paolo Abeni , Peter Zijlstra , Richard Weinberger , Russell King , Theodore Ts'o , Thomas Bogendoerfer , Thomas Gleixner , Thomas Graf , Ulf Hansson , Vignesh Raghavendra , WANG Xuerui , Will Deacon , Yury Norov , "dri-devel@lists.freedesktop.org" , "kasan-dev@googlegroups.com" , "kernel-janitors@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-block@vger.kernel.org" , "linux-crypto@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-media@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-mm@kvack.org" , "linux-mmc@vger.kernel.org" , "linux-mtd@lists.infradead.org" , "linux-nvme@lists.infradead.org" , "linux-parisc@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-um@lists.infradead.org" , "linux-usb@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "loongarch@lists.linux.dev" , "netdev@vger.kernel.org" , "sparclinux@vger.kernel.org" , "x86@kernel.org" , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Chuck Lever , Jan Kara T24gMTAvNi8yMiwgQ2hyaXN0b3BoZSBMZXJveSA8Y2hyaXN0b3BoZS5sZXJveUBjc2dyb3VwLmV1 PiB3cm90ZToKPgo+Cj4gTGUgMDYvMTAvMjAyMiDDoCAxOTozMSwgQ2hyaXN0b3BoZSBMZXJveSBh IMOpY3JpdCA6Cj4+Cj4+Cj4+IExlIDA2LzEwLzIwMjIgw6AgMTk6MjQsIEphc29uIEEuIERvbmVu ZmVsZCBhIMOpY3JpdCA6Cj4+PiBIaSBDaHJpc3RvcGhlLAo+Pj4KPj4+IE9uIFRodSwgT2N0IDYs IDIwMjIgYXQgMTE6MjEgQU0gQ2hyaXN0b3BoZSBMZXJveQo+Pj4gPGNocmlzdG9waGUubGVyb3lA Y3Nncm91cC5ldT4gd3JvdGU6Cj4+Pj4gTGUgMDYvMTAvMjAyMiDDoCAxODo1MywgSmFzb24gQS4g RG9uZW5mZWxkIGEgw6ljcml0IDoKPj4+Pj4gVGhlIHByYW5kb21fdTMyKCkgZnVuY3Rpb24gaGFz IGJlZW4gYSBkZXByZWNhdGVkIGlubGluZSB3cmFwcGVyIGFyb3VuZAo+Pj4+PiBnZXRfcmFuZG9t X3UzMigpIGZvciBzZXZlcmFsIHJlbGVhc2VzIG5vdywgYW5kIGNvbXBpbGVzIGRvd24gdG8gdGhl Cj4+Pj4+IGV4YWN0IHNhbWUgY29kZS4gUmVwbGFjZSB0aGUgZGVwcmVjYXRlZCB3cmFwcGVyIHdp dGggYSBkaXJlY3QgY2FsbCB0bwo+Pj4+PiB0aGUgcmVhbCBmdW5jdGlvbi4gVGhlIHNhbWUgYWxz byBhcHBsaWVzIHRvIGdldF9yYW5kb21faW50KCksIHdoaWNoIGlzCj4+Pj4+IGp1c3QgYSB3cmFw cGVyIGFyb3VuZCBnZXRfcmFuZG9tX3UzMigpLgo+Pj4+Pgo+Pj4+PiBSZXZpZXdlZC1ieTogS2Vl cyBDb29rIDxrZWVzY29va0BjaHJvbWl1bS5vcmc+Cj4+Pj4+IEFja2VkLWJ5OiBUb2tlIEjDuGls YW5kLUrDuHJnZW5zZW4gPHRva2VAdG9rZS5kaz4gIyBmb3Igc2NoX2Nha2UKPj4+Pj4gQWNrZWQt Ynk6IENodWNrIExldmVyIDxjaHVjay5sZXZlckBvcmFjbGUuY29tPiAjIGZvciBuZnNkCj4+Pj4+ IFJldmlld2VkLWJ5OiBKYW4gS2FyYSA8amFja0BzdXNlLmN6PiAjIGZvciBleHQ0Cj4+Pj4+IFNp Z25lZC1vZmYtYnk6IEphc29uIEEuIERvbmVuZmVsZCA8SmFzb25AengyYzQuY29tPgo+Pj4+PiAt LS0KPj4+Pgo+Pj4+PiBkaWZmIC0tZ2l0IGEvYXJjaC9wb3dlcnBjL2tlcm5lbC9wcm9jZXNzLmMK Pj4+Pj4gYi9hcmNoL3Bvd2VycGMva2VybmVsL3Byb2Nlc3MuYwo+Pj4+PiBpbmRleCAwZmJkYTg5 Y2QxYmIuLjljNGMxNWFmYmJlOCAxMDA2NDQKPj4+Pj4gLS0tIGEvYXJjaC9wb3dlcnBjL2tlcm5l bC9wcm9jZXNzLmMKPj4+Pj4gKysrIGIvYXJjaC9wb3dlcnBjL2tlcm5lbC9wcm9jZXNzLmMKPj4+ Pj4gQEAgLTIzMDgsNiArMjMwOCw2IEBAIHZvaWQgbm90cmFjZSBfX3BwYzY0X3J1bmxhdGNoX29m Zih2b2lkKQo+Pj4+PiAgICB1bnNpZ25lZCBsb25nIGFyY2hfYWxpZ25fc3RhY2sodW5zaWduZWQg bG9uZyBzcCkKPj4+Pj4gICAgewo+Pj4+PiAgICAgICAgaWYgKCEoY3VycmVudC0+cGVyc29uYWxp dHkgJiBBRERSX05PX1JBTkRPTUlaRSkgJiYKPj4+Pj4gcmFuZG9taXplX3ZhX3NwYWNlKQo+Pj4+ PiAtICAgICAgICAgICAgIHNwIC09IGdldF9yYW5kb21faW50KCkgJiB+UEFHRV9NQVNLOwo+Pj4+ PiArICAgICAgICAgICAgIHNwIC09IGdldF9yYW5kb21fdTMyKCkgJiB+UEFHRV9NQVNLOwo+Pj4+ PiAgICAgICAgcmV0dXJuIHNwICYgfjB4ZjsKPj4+Pgo+Pj4+IElzbid0IHRoYXQgYSBjYW5kaWRh dGUgZm9yIHByYW5kb21fdTMyX21heCgpID8KPj4+Pgo+Pj4+IE5vdGUgdGhhdCBzcCBpcyBkZWVt ZWQgdG8gYmUgMTYgYnl0ZXMgYWxpZ25lZCBhdCBhbGwgdGltZS4KPj4+Cj4+PiBZZXMsIHByb2Jh Ymx5LiBJdCBzZWVtZWQgbm9uLXRyaXZpYWwgdG8gdGhpbmsgYWJvdXQsIHNvIEkgZGlkbid0LiBC dXQKPj4+IGxldCdzIHNlZSBoZXJlLi4uIG1heWJlIGl0J3Mgbm90IHRvbyBiYWQ6Cj4+Pgo+Pj4g SWYgUEFHRV9NQVNLIGlzIGFsd2F5cyB+KFBBR0VfU0laRS0xKSwgdGhlbiB+UEFHRV9NQVNLIGlz Cj4+PiAoUEFHRV9TSVpFLTEpLCBzbyBwcmFuZG9tX3UzMl9tYXgoUEFHRV9TSVpFKSBzaG91bGQg eWllbGQgdGhlIHNhbWUKPj4+IHRoaW5nPyBJcyB0aGF0IGFjY3VyYXRlPyBBbmQgaG9sZHMgYWNy b3NzIHBsYXRmb3JtcyAodGhpcyBjb21lcyB1cCBhCj4+PiBmZXcgcGxhY2VzKT8gSWYgc28sIEkn bGwgZG8gdGhhdCBmb3IgYSB2NC4KPj4+Cj4+Cj4+IE9uIHBvd2VycGMgaXQgaXMgYWx3YXlzIChm cm9tIGFyY2gvcG93ZXJwYy9pbmNsdWRlL2FzbS9wYWdlLmgpIDoKPj4KPj4gLyoKPj4gICAqIFN1 YnRsZTogKDEgPDwgUEFHRV9TSElGVCkgaXMgYW4gaW50LCBub3QgYW4gdW5zaWduZWQgbG9uZy4g U28gaWYgd2UKPj4gICAqIGFzc2lnbiBQQUdFX01BU0sgdG8gYSBsYXJnZXIgdHlwZSBpdCBnZXRz IGV4dGVuZGVkIHRoZSB3YXkgd2Ugd2FudAo+PiAgICogKGkuZS4gd2l0aCAxcyBpbiB0aGUgaGln aCBiaXRzKQo+PiAgICovCj4+ICNkZWZpbmUgUEFHRV9NQVNLICAgICAgKH4oKDEgPDwgUEFHRV9T SElGVCkgLSAxKSkKPj4KPj4gI2RlZmluZSBQQUdFX1NJWkUgICAgICAgICgxVUwgPDwgUEFHRV9T SElGVCkKPj4KPj4KPj4gU28gaXQgd291bGQgd29yayBJIGd1ZXNzLgo+Cj4gQnV0IHRha2luZyBp bnRvIGFjY291bnQgdGhhdCBzcCBtdXN0IHJlbWFpbiAxNiBieXRlcyBhbGlnbmVkLCB3b3VsZCBp dAo+IGJlIGJldHRlciB0byBkbyBzb21ldGhpbmcgbGlrZSA/Cj4KPiAJc3AgLT0gcHJhbmRvbV91 MzJfbWF4KFBBR0VfU0laRSA+PiA0KSA8PCA0Owo+Cj4gCXJldHVybiBzcDsKCkRvZXMgdGhpcyBh c3N1bWUgdGhhdCBzcCBpcyBhbHJlYWR5IGFsaWduZWQgYXQgdGhlIGJlZ2lubmluZyBvZiB0aGUK ZnVuY3Rpb24/IEknZCBhc3N1bWUgZnJvbSB0aGUgZnVuY3Rpb24ncyBuYW1lIHRoYXQgdGhpcyBp c24ndCB0aGUKY2FzZT8KCkphc29uCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpsaW51eC11bSBtYWlsaW5nIGxpc3QKbGludXgtdW1AbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LXVtCg==