public inbox for linux-um@lists.infradead.org
 help / color / mirror / Atom feed
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>
Cc: "David Gow" <davidgow@google.com>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Anton Ivanov" <anton.ivanov@cambridgegreys.com>,
	"Johannes Berg" <johannes@sipsolutions.net>,
	<driver-core@lists.linux.dev>,
	"linux-um" <linux-um@lists.infradead.org>,
	"rust-for-linux" <rust-for-linux@vger.kernel.org>
Subject: Re: Mainline UML Rust stable io.rs unused imports
Date: Mon, 16 Feb 2026 11:34:56 +0100	[thread overview]
Message-ID: <DGGBI4DU4J4U.2JOBHL5IFUCTL@kernel.org> (raw)
In-Reply-To: <CANiq72khOYkt6t5zwMvSiyZvWWHMZuNCMERXu=7K=_5tT-8Pgg@mail.gmail.com>

On Sun Feb 15, 2026 at 1:47 PM CET, Miguel Ojeda wrote:
> Hi all,
>
> In mainline and next, for UML with Rust stable (but not with Rust
> minimum), I am seeing:

I think the problem is not UML specific, it is about define_read!() and
define_write!() being crate public, while the only user is PCI.

So, if CONFIG_PCI=n, we get this warning.

I will send a fix soon.

Thanks for reporting!

- Danilo

>
>       RUSTC L rust/kernel.o - due to target missing
>     error: unused import: `define_read`
>        --> rust/kernel/io.rs:229:16
>         |
>     229 | pub(crate) use define_read;
>         |                ^^^^^^^^^^^
>         |
>         = note: `-D unused-imports` implied by `-D warnings`
>         = help: to override `-D warnings` add `#[allow(unused_imports)]`
>
>     error: unused import: `define_write`
>        --> rust/kernel/io.rs:262:16
>         |
>     262 | pub(crate) use define_write;
>         |                ^^^^^^^^^^^
>
> Cheers,
> Miguel



  parent reply	other threads:[~2026-02-16 10:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-15 12:47 Mainline UML Rust stable io.rs unused imports Miguel Ojeda
2026-02-16 10:19 ` Johannes Berg
2026-02-16 10:34 ` Danilo Krummrich [this message]
2026-02-16 13:22   ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGGBI4DU4J4U.2JOBHL5IFUCTL@kernel.org \
    --to=dakr@kernel.org \
    --cc=aliceryhl@google.com \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=daniel.almeida@collabora.com \
    --cc=davidgow@google.com \
    --cc=driver-core@lists.linux.dev \
    --cc=johannes@sipsolutions.net \
    --cc=linux-um@lists.infradead.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=richard@nod.at \
    --cc=rust-for-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox