[uml-devel] A few comments on hostfs interface

[Paul Wagland <paul@kungfoocoder.org>]

[-- Attachment #1: Type: text/plain, Size: 898 bytes --]

Hi all,

These comments are based on the development code as provided by sikkh, 
as such not everything might be relevant, but I believe that the 
primary code changed by sikkh is in the metadata interface.

Anyway, here goes:

hostfs.h:

   struct externfs_file_ops:
     Almost all of the functions have the naming form verb_noun, except 
for file_create(). I would suggest to reverse this for the sake of 
consistency.

     Most functions have "long names" that is open_file, link_file, 
access_file, etc. The exceptions to this are mkdir(), rmdir(), mknod(), 
readlink(), and statfs(). This cannot be done to "keep standard 
semantics" since open_dir() is not in it's standard form either. I 
would suggest to rename all of the "short form" functions into the 
standardised form.

Jeff, if you agree with the above, let me know, and you will receive a 
patch for it later today.

Cheers,
Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 186 bytes --]