From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Jeff Dike <jdike@addtoit.com>
Cc: user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] potentially dead CONFIG variables under arch/um
Date: Tue, 17 Jul 2007 12:04:44 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0707171200290.2620@localhost.localdomain> (raw)
In-Reply-To: <20070717155555.GA7965@c2.user-mode-linux.org>
On Tue, 17 Jul 2007, Jeff Dike wrote:
> Oops, sorry for ignoring your last post...
>
> On Tue, Jul 17, 2007 at 07:24:09AM -0400, Robert P. J. Day wrote:
> >
> > ========== HARDDOG_NOWAYOUT ==========
> > arch/um/drivers/harddog_kern.c:72:#ifdef CONFIG_HARDDOG_NOWAYOUT
>
> This looks bogus. There is a WATCHDOG_NOWAYOUT and I think we
> should use that instead.
be careful, as there are two different Kconfig files that define that
Kconfig variable:
$ grep -w WATCHDOG_NOWAYOUT $(find . -name Kconfig*)
./drivers/char/watchdog/Kconfig:config WATCHDOG_NOWAYOUT
./arch/um/Kconfig.char:config WATCHDOG_NOWAYOUT
just making sure you noticed that.
> > ========== PROC_MM ==========
> > arch/um/kernel/ptrace.c:13:#ifdef CONFIG_PROC_MM
> > arch/um/kernel/ptrace.c:227:#ifdef CONFIG_PROC_MM
> > ========== TTY_LOG ==========
> > arch/um/os-Linux/Makefile:15:obj-$(CONFIG_TTY_LOG) += tty_log.o
> > arch/um/os-Linux/Makefile:16:user-objs-$(CONFIG_TTY_LOG) += tty_log.o
> > arch/um/kernel/exec.c:34:#ifdef CONFIG_TTY_LOG
> > arch/um/kernel/exec.c:42:#ifdef CONFIG_TTY_LOG
>
> These two are used, but in code which is not yet merged. These
> references leaked into mainline by accident.
>
> Jeff
so i'll leave the above in your capable hands, then.
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
prev parent reply other threads:[~2007-07-17 16:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-17 11:24 [uml-devel] potentially dead CONFIG variables under arch/um Robert P. J. Day
2007-07-17 15:55 ` Jeff Dike
2007-07-17 16:04 ` Robert P. J. Day [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0707171200290.2620@localhost.localdomain \
--to=rpjday@mindspring.com \
--cc=jdike@addtoit.com \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox