From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f196.google.com ([209.85.214.196]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kgd59-0002Hm-MM for linux-um@lists.infradead.org; Sun, 22 Nov 2020 00:18:20 +0000 Received: by mail-pl1-f196.google.com with SMTP id 5so6934860plj.8 for ; Sat, 21 Nov 2020 16:18:12 -0800 (PST) Date: Sat, 21 Nov 2020 16:18:10 -0800 From: Moritz Fischer Subject: Re: [PATCH v2] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL Message-ID: References: <20201120234648.4050910-1-davidgow@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201120234648.4050910-1-davidgow@google.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: David Gow Cc: Tom Rix , linux-fpga@vger.kernel.org, linux-um , Linux Kernel Mailing List , Moritz Fischer , Xu Yilun , Brendan Higgins On Fri, Nov 20, 2020 at 03:46:48PM -0800, David Gow wrote: > Because dfl.c uses the 'devm_ioremap', 'devm_iounmap', > 'devm_ioremap_resource', and 'devm_platform_ioremap_resource' > functions, it should depend on HAS_IOMEM. > > This fixes make allyesconfig under UML (ARCH=um), which doesn't provide > HAS_IOMEM. > > Fixes: 89eb35e810a8 ("fpga: dfl: map feature mmio resources in their own feature drivers") > Signed-off-by: David Gow > --- > > Changes since v1: > ( https://lore.kernel.org/linux-fpga/20201119082209.3598354-1-davidgow@google.com/ ) > - Add Fixes tag > > drivers/fpga/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig > index 7cd5a29fc437..5645226ca3ce 100644 > --- a/drivers/fpga/Kconfig > +++ b/drivers/fpga/Kconfig > @@ -142,6 +142,7 @@ config FPGA_DFL > tristate "FPGA Device Feature List (DFL) support" > select FPGA_BRIDGE > select FPGA_REGION > + depends on HAS_IOMEM > help > Device Feature List (DFL) defines a feature list structure that > creates a linked list of feature headers within the MMIO space > -- > 2.29.2.454.gaff20da3a2-goog > Applied to for-5.10, I fixed up your commit message (dropped the drivers:) - Moritz _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um